Fixed message manager test not waiting long enough; hopefully fixed p…

…assword tests by adding missing dependencies to ci
PhilInTheGaps · Nov 3, 2023 · d0940d6 · d0940d6
1 parent bfd1b35
commit d0940d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -138,7 +138,7 @@ jobs:
           sudo add-apt-repository universe
           sudo apt-get update -q
           sudo apt-get upgrade -q
-          sudo apt install -qq mesa-common-dev libglu1-mesa-dev libfreetype6-dev libfontconfig1-dev libjpeg-turbo8-dev libtiff-dev libnss3-dev libopenjp2-7-dev libboost-dev libcairo2-dev libcurl4-openssl-dev python3-setuptools patchelf libasound2-dev libsecret-1-dev libxcb-cursor0 libfuse2
+          sudo apt install -qq mesa-common-dev libglu1-mesa-dev libfreetype6-dev libfontconfig1-dev libjpeg-turbo8-dev libtiff-dev libnss3-dev libopenjp2-7-dev libboost-dev libcairo2-dev libcurl4-openssl-dev python3-setuptools patchelf libasound2-dev libsecret-1-dev gnome-keyring dbus-x11 libxcb-cursor0 libfuse2
 
       - name: Install Qt
         uses: jurplel/install-qt-action@v3
@@ -256,7 +256,7 @@ jobs:
         run: |
           sudo apt-get update -q
           sudo apt-get upgrade -q
-          sudo apt install -qq mesa-common-dev libglu1-mesa-dev libfreetype6-dev libfontconfig1-dev libjpeg-turbo8-dev libtiff-dev libnss3-dev libopenjp2-7-dev libboost-dev libcairo2-dev libcurl4-openssl-dev python3-setuptools patchelf libasound2-dev libsecret-1-dev libxcb-cursor0
+          sudo apt install -qq mesa-common-dev libglu1-mesa-dev libfreetype6-dev libfontconfig1-dev libjpeg-turbo8-dev libtiff-dev libnss3-dev libopenjp2-7-dev libboost-dev libcairo2-dev libcurl4-openssl-dev python3-setuptools patchelf libasound2-dev libsecret-1-dev gnome-keyring dbus-x11 libxcb-cursor0
           sudo pip3 install gcovr
 
       - name: Install Qt

diff --git a/tests/messages/testmessagemanager.cpp b/tests/messages/testmessagemanager.cpp
@@ -1,5 +1,6 @@
 #include "messages/messagemanager.h"
 #include <QFuture>
+#include <QTest>
 #include <QtConcurrent/QtConcurrent>
 #include <gtest/gtest.h>
 
@@ -52,6 +53,8 @@ TEST(MessageManagerTest, CanAddMessagesFromDifferentThreads)
         MessageManager::instance()->addMessage(std::move(message2));
     }).waitForFinished();
 
+    QTest::qWait(50);
+
     EXPECT_EQ(MessageManager::instance()->messages()->rowCount(), 3);
 }