Conjoin search input and button #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we want form elements (buttons, inputs) to appear collected together in a group, such as a text input with a conjoined submit button. This commit adds a `FormElementGroup` component that allows for this, with both horizontal (default) and vertical variants.
The proposal list search input and button should be joined into a group.
✅ Deploy Preview for philanthropy-data-commons-viewer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bickelj
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
FormElementGroupcomponent that we can use to conjoin form elements (buttons, inputs) into horizontal or vertical groups. It also applies that component to the search atop the proposal list table, so the search input and its submit button are visually bound.Before:
After:
Testing:
npm startnpm run storybookFormElementGroupdocs and confirm they are 👍