Unsafe argument of type any on PlatformProviderResponse.data
#1013
Comments
|
Part of the issue here is that it basically is an I think for this one you should just use a lint disable, and we know we'll be refactoring this functionality / properly implementing it down the line. What do you think? |
|
Perfectly fine by me. |
|
I should close this with the appropriate status! |
In order to do this, we needed to disable the ESLint complaint about the `data` property being an `any`. This is allowable because in this ersatz implementation of a provider response, we don’t know the shape of the data.[1] Issue #737 Replace `PlatformProviderResponse` type with SDK version [1] PhilanthropyDataCommons/service#1013 (comment)
|
@slifty 😮 how do you get credit for closing this as not planned? I thought I did that! Here, I'm gonna steal credit. |
|
Ohhh, I see now. I changed the drop-down to "Close as not planned" but didn't actually click the Close button. I didn't realize it was a two-step. This was useful for more than just narcissism. |
In order to do this, we needed to disable the ESLint complaint about the `data` property being an `any`. This is allowable because in this ersatz implementation of a provider response, we don’t know the shape of the data.[1] Issue #737 Replace `PlatformProviderResponse` type with SDK version [1] PhilanthropyDataCommons/service#1013 (comment)
|
@slifty discovered that swagger-codegen incorrectly translates Thus, we can actually reopen this issue and consider it blocked until either swagger-codegen is fixed or we move to openapi-generator for SDK generation. |
In order to do this, we needed to disable the ESLint complaint about the `data` property being an `any`. Which itself is due to an upstream bug in our current SDK generator[1]; once fixed, we can remove this disable. Issue #737 Replace `PlatformProviderResponse` type with SDK version [1] PhilanthropyDataCommons/service#1013 (comment)
When using the
PlatformProviderResponsetype, accessing thedataproperty nets ye olde complainte:Here's the line that actually calls the
dataproperty: https://github.com/PhilanthropyDataCommons/front-end/blob/3e39eb2f5815dd0de2caf03733d94242475465ef/src/components/DataPlatformProvider/DataPlatformProviderLoader.tsx#L190Unsure if this should be part of #1004 or is separate.
The text was updated successfully, but these errors were encountered: