Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide visibility of application form fields #132

Closed
bickelj opened this issue Nov 30, 2022 · 1 comment
Closed

Provide visibility of application form fields #132

bickelj opened this issue Nov 30, 2022 · 1 comment
Assignees

Comments

@bickelj
Copy link
Contributor

bickelj commented Nov 30, 2022

Right now you can post an applicationForm, complete with fields, to /applicationForms, but you cannot see those same fields when calling get /applicationForms. We might be able to resolve also with /applicationFormFields but that would require more processing and so forth to combine the form fields from a single form together.

@bickelj bickelj self-assigned this Dec 6, 2022
bickelj added a commit that referenced this issue Dec 7, 2022
Similar to the POST /applicationForms, include the application form
fields when calling GET. There is some redudancy in the data coming
back but that is consistent with the given types and JSON schemas.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 12, 2022
Similar to the POST /applicationForms, include the application form
fields when calling GET. There is some redudancy in the data coming
back but that is consistent with the given types and JSON schemas.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 12, 2022
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 12, 2022
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 12, 2022
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 16, 2022
Similar to the POST /applicationForms, include the application form
fields when calling GET. There is some redudancy in the data coming
back but that is consistent with the given types and JSON schemas.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 16, 2022
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Dec 16, 2022
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms`, otherwise a
shallow response with only direct attributes on application form will
be returned.

This is a compromise that provides the same convenience on `GET
/applicationForms` as is present on `POST /applicationForms` but keeps
the ability to GET only the shallow attributes.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 9, 2023
Similar to the POST /applicationForms, include the application form
fields when calling GET. There is some redudancy in the data coming
back but that is consistent with the given types and JSON schemas.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 9, 2023
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 9, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms`, otherwise a
shallow response with only direct attributes on application form will
be returned.

This is a compromise that provides the same convenience on `GET
/applicationForms` as is present on `POST /applicationForms` but keeps
the ability to GET only the shallow attributes.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 9, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 10, 2023
Similar to the POST /applicationForms, include the application form
fields when calling GET. There is some redudancy in the data coming
back but that is consistent with the given types and JSON schemas.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 10, 2023
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 10, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms`, otherwise a
shallow response with only direct attributes on application form will
be returned.

This is a compromise that provides the same convenience on `GET
/applicationForms` as is present on `POST /applicationForms` but keeps
the ability to GET only the shallow attributes.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 10, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Similar to the POST /applicationForms, include the application form
fields when calling GET. There is some redudancy in the data coming
back but that is consistent with the given types and JSON schemas.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
* Factor out a function from the previous commit and add a test.
* Update the OpenAPI documentation.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms`, otherwise a
shallow response with only direct attributes on application form will
be returned.

This is a compromise that provides the same convenience on `GET
/applicationForms` as is present on `POST /applicationForms` but keeps
the ability to GET only the shallow attributes.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

This commit combines four commits from 2022-12-06, 2022-12-12,
2022-12-12, 2022-12-16, 2023-02-09, respectively, and cleanup on
2023-02-13. Some history of changes should be available at
#157

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

This commit combines four commits from 2022-12-06, 2022-12-12,
2022-12-12, 2022-12-16, 2023-02-09, respectively, and cleanup on
2023-02-13. Some history of changes should be available at
#157

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

This commit combines four commits from 2022-12-06, 2022-12-12,
2022-12-12, 2022-12-16, 2023-02-09, respectively, and cleanup on
2023-02-13. Some history of changes should be available at
#157

Issue #132 Provide visibility of application form fields
bickelj added a commit that referenced this issue Feb 13, 2023
Use query parameter `includeFields=true` to include application form
fields in the response from `GET /applicationForms/{id}`, otherwise a
shallow response with only direct attributes on application form will
be returned.

The implementation is more akin to the one for /proposals in PR #210.

This commit combines four commits from 2022-12-06, 2022-12-12,
2022-12-12, 2022-12-16, 2023-02-09, respectively, and cleanup on
2023-02-13. Some history of changes should be available at
#157

Issue #132 Provide visibility of application form fields
@bickelj
Copy link
Contributor Author

bickelj commented Feb 27, 2023

Resolved by merge of #157

@bickelj bickelj closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant