Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 #675

Closed
slifty opened this issue Dec 19, 2023 · 6 comments
Closed

Update to Node 20 #675

slifty opened this issue Dec 19, 2023 · 6 comments

Comments

@slifty
Copy link
Member

slifty commented Dec 19, 2023

From the recent graphile-worker dependabot PR:

As of 24th October 2023, Node 20 is the active LTS and Node 18 is maintainence LTS

Is there a reason we should avoid updating?

@slifty slifty changed the title Update to Node 20? Update to Node 20 Dec 19, 2023
@slifty
Copy link
Member Author

slifty commented Dec 20, 2023

Realizing this might be easier to do after completing #622 -- I may wait to take it on until then.

@jasonaowen
Copy link
Contributor

Yeah, I think the only reason to avoid/defer uploading is because of the associated infra work - it should be easier as a DO App!

@bickelj
Copy link
Contributor

bickelj commented Jan 12, 2024

Does DO separate the node version from the codebase? Of course that would be easier but with its own costs.

@bickelj
Copy link
Contributor

bickelj commented Mar 19, 2024

(See #833 discussion)

I just tried running npm ci and npm run build using node 18, then did npm run migrate and npm run start and all seemed OK. I'll update node to 20 in the deploy repo (runtime) and then @slifty volunteered to update it here in the service repo (build time).

So I got mixed up (been a while) it's all defined here in the service repo. I'll take a first pass at updating.

bickelj added a commit that referenced this issue Mar 19, 2024
Issue #675 Update to Node 20
Issue #833 Build(deps-dev): bump the eslint group with 2 updates
@bickelj
Copy link
Contributor

bickelj commented Mar 19, 2024

@slifty OK, first pass is in PR #837 but I may have missed some spots or it may fail, I hereby leave that branch to thee!

bickelj added a commit that referenced this issue Mar 20, 2024
Issue #675 Update to Node 20
Issue #833 Build(deps-dev): bump the eslint group with 2 updates
bickelj added a commit that referenced this issue Mar 20, 2024
Issue #675 Update to Node 20
Issue #833 Build(deps-dev): bump the eslint group with 2 updates
@slifty
Copy link
Member Author

slifty commented Mar 21, 2024

This is complete 🎉

@slifty slifty closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants