Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data type URL enum value to be url #989

Closed
slifty opened this issue May 3, 2024 · 0 comments · Fixed by #1032
Closed

Update data type URL enum value to be url #989

slifty opened this issue May 3, 2024 · 0 comments · Fixed by #1032
Assignees
@hminsky2002

Comments

@slifty
Copy link
Member

slifty commented May 3, 2024 •
edited by reefdog
Loading

@slifty Ah, I'm glad you asked! Yes, I would expect the value to be lowercase. At least, alongside the other enum values:

export enum BaseFieldDataType {
	STRING = 'string',
	NUMBER = 'number',
	PHONE_NUMBER = 'phone_number',
	EMAIL = 'email',
	URL = 'URL',
	BOOLEAN = 'boolean',
}

Originally posted by @reefdog in #975 (comment)

Our enum values are all snake_case except for URL which has capitalization. We should be consistent. Yes this does mean creating a migration unfortunately, but that's OK!
hminsky2002 added a commit that referenced this issue May 24, 2024
@hminsky2002
Update URL to url in field_type enum
83ee966 
This commit remedies a typo from the field_type enum, which is used to
validate the type of a basefield. The value of 'url' was originally
capitalized as 'URL', but this goes against our convention. It adds a
new migration, and updates the seed file accordingly

Issue #989 Update URL enum value to url
@hminsky2002 hminsky2002 mentioned this issue May 24, 2024
Merged
hminsky2002 added a commit that referenced this issue May 24, 2024
@hminsky2002
Update URL to url in field_type enum
4ee3d3a 
This commit remedies a typo from the field_type enum, which is used to
validate the type of a basefield. The value of 'url' was originally
capitalized as 'URL', but this goes against our convention. It adds a
new migration, and updates the seed file accordingly

Issue #989 Update URL enum value to url
hminsky2002 added a commit that referenced this issue Jul 16, 2024
@hminsky2002
Update URL to url in field_type enum
7b54f46 
This commit remedies a typo from the field_type enum, which is used to
validate the type of a basefield. The value of 'url' was originally
capitalized as 'URL', but this goes against our convention. It adds a
new migration, and updates the seed file accordingly

Issue #989 Update URL enum value to url
hminsky2002 added a commit that referenced this issue Jul 16, 2024
@hminsky2002
Update URL to url in field_type enum
e624de1 
This commit remedies a typo from the field_type enum, which is used to
validate the type of a basefield. The value of 'url' was originally
capitalized as 'URL', but this goes against our convention. It adds a
new migration, and updates the seed file accordingly

Issue #989 Update URL enum value to url
hminsky2002 added a commit that referenced this issue Jul 17, 2024
@hminsky2002
Update URL to url in field_type enum
3e56720 
This commit remedies a typo from the field_type enum, which is used to
validate the type of a basefield. The value of 'url' was originally
capitalized as 'URL', but this goes against our convention. It adds a
new migration, and updates the seed file accordingly

Issue #989 Update URL enum value to url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hminsky2002 hminsky2002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update URL to url in field_type enum PhilanthropyDataCommons/service
2 participants
@slifty @hminsky2002