add pin completion listener #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the keyboard on smaller screen devices
# Conflicts: # pinentry/src/main/java/me/philio/pinentry/PinEntryView.java # pinentry/src/main/res/values/attrs.xml
|
merged upstream changes to resolve merge conflicts |
|
Do you think you'll get a chance to review this @Philio ? |
|
Oops sorry @CDRussell, I'll check it now |
| @@ -316,6 +333,7 @@ private void addViews() { | |||
| editText.setFilters(new InputFilter[]{new InputFilter.LengthFilter(digits)}); | |||
| editText.setInputType(inputType); | |||
| editText.setImeOptions(EditorInfo.IME_FLAG_NO_EXTRACT_UI); | |||
| editText.setPadding(editText.getPaddingLeft(), editText.getPaddingTop(), editText.getPaddingRight(), 100); | |||
There was a problem hiding this comment.
Why does the hidden EditText need padding?
There was a problem hiding this comment.
Hi @Philio, good catch; this does look like a mistake. I've removed this change.
|
Hi, is this going to make it into a release soon? It's the exact functionality we're looking for in our app but I notice it isn't in 1.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gives a way to specify a callback which will be given the pin as soon as all of the digits have been entered.