Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing items from CMakeFile #136

Merged
merged 1 commit into from
Jul 23, 2017
Merged

Removing items from CMakeFile #136

merged 1 commit into from
Jul 23, 2017

Conversation

demonpig
Copy link
Contributor

Reason for removing check for webkit2gtk was that webkit2gtk-3.0
is no longer supported by Notes-Up.

Reason for removing PKG_DEPS variable is that it was unnecessary
since package dependencies are already checked before the variable
is set.

Reason for removing check for webkit2gtk was that webkit2gtk-3.0
is no longer supported by Notes-Up.

Reason for removing PKG_DEPS variable is that it was unnecessary
since package dependencies are already checked before the variable
is set.
@demonpig
Copy link
Contributor Author

This commit will allow people with Cmake 3.8 to compile the program without editing the CMakeFile.

Reference: #199

@Mailaender
Copy link
Contributor

I can confirm that this patch helps https://build.opensuse.org/request/show/512129

@Philip-Scott Philip-Scott merged commit 761b32c into Philip-Scott:master Jul 23, 2017
@Philip-Scott
Copy link
Owner

@demonpig You've officially killed Notes-Up updates for people that are still in Freya or bellow 😄

Yeah, the reason that was still there is because it's being still built for Freya. But, it's a good day to make people update, don't you think 😉

@demonpig
Copy link
Contributor Author

@Philip-Scott Whoops! :)

I do wonder how the build was working anyways since I tried to build the application on Freya but received build errors due to webkit2gtk-4 being required. Regardless, i am working on the AppImage of the application so if they need an updated version, then people can use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants