Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tradeoffer accept #35

Closed
wants to merge 3 commits into from
Closed

Fix tradeoffer accept #35

wants to merge 3 commits into from

Conversation

TwinkerMan
Copy link

No description provided.

@b1naryth1ef
Copy link
Contributor

Why change the original structure around the usage of baseurl? Also can you give a reason as to removing tradeofferid from the params? AFAIK this is still required.

@TwinkerMan
Copy link
Author

tradeofferid don't required because tradeofferid stay in URL

Bot log (MSK time):
2015/06/17 13:42:26 Connected
2015/06/17 13:42:26 Loggind on
2015/06/17 13:42:27 Logged on
2015/06/17 13:42:28 Web logging on
2015/06/17 13:42:29 Successfully logged on web
2015/06/17 13:42:30 Processing TOffer with ID 532196644
2015/06/17 13:42:30 Processing TOffer with ID 532196265
2015/06/17 13:42:30 Processing TOffer with ID 532196010
2015/06/17 13:42:35 TradeOfferId 532196010 accepted
2015/06/17 13:42:37 TradeOfferId 532196265 accepted
2015/06/17 13:42:42 TradeOfferId 532196644 accepted

Steam (MSK time):
Trade Accepted 17 Jun, 2015 @ 1:42pm
Trade Accepted 17 Jun, 2015 @ 1:42pm
Trade Accepted 17 Jun, 2015 @ 1:42pm

Trouble could be in tradeoffer POST param (not in referer). IDK (dat Steam...)

@Philipp15b
Copy link
Owner

So your fix basically consists of removing the tradeofferid parameter? An additional parameter shouldn't be a problem. Moreover, I can't find evidence elsewhere that Steam now rejects that parameter; node-steam-tradeoffers for example still sends it and SteamBot does too. Finally, Valve itself sends it in their economy_tradeoffer.js via their web interface.

Have you considered the API temporarily not working? From what I've seen, that's quite common with Valve APIs.

@Philipp15b Philipp15b closed this Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants