Made EmailDomain Accessable Before Successful Login #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added access to EmailDomain on LogonResponse event
Sorry, I'm just learning more about pull requests. I was just testing something with this and the previous commit.
Philipp15b
reviewed
Aug 18, 2018
| @@ -157,6 +157,7 @@ func (c *Client) ConnectToBind(addr *netutil.PortAddr, local *net.TCPAddr) { | |||
| conn, err := dialTCP(local, addr.ToTCPAddr()) | |||
| if err != nil { | |||
| c.Fatalf("Connect failed: %v", err) | |||
| c.Connect() | |||
There was a problem hiding this comment.
Why the additional connect call here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you wanted to retrieve the Steam client's email domain (gmail.com), you had to sucessfully login to Steam and access it with the LoggedOnEvent. Now you will be able to access the client's email domain from a LogOnFailedEvent.
With the SteamKit2, you are able to access the EmailDomain before a successful logon. This is so you can prompt the user to check their email at gmail.com (or their own email domain).