Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the dependency on Spyc external #36

Closed
PerWiklander opened this issue Feb 21, 2017 · 2 comments · Fixed by #38
Closed

Make the dependency on Spyc external #36

PerWiklander opened this issue Feb 21, 2017 · 2 comments · Fixed by #38

Comments

@PerWiklander
Copy link
Contributor

Spyc has a composer package: https://packagist.org/packages/mustangostang/spyc, so there is no need to include it in this repository.
@Philipp15b
Copy link
Owner

Making spyc a composer dependency also makes composer a hard dependency of the project, which I was initially hesitant to commit to. I am happy to merge pull requests to fix this now though.

@PerWiklander
Copy link
Contributor Author

I've started work on this PR now. I just have a question about the project license. The existing composer.json claims "CC BY-SA 3.0" while LICENSE.txt says "MIT", which one is it?

PerWiklander added a commit to PerWiklander/php-i18n that referenced this issue Mar 20, 2017
@PerWiklander
Philipp15b#36 Makes the dependency on Spyc explicit in composer.json
e2967ac
@PerWiklander PerWiklander mentioned this issue Mar 20, 2017
Merged
3 tasks
Philipp15b added a commit that referenced this issue Mar 21, 2018
@Philipp15b
Merge branch 'feature/36_Make_the_dependency_on_Spyc_external' of htt…
97663ee 
…ps://github.com/PerWiklander/php-i18n

Fixes #36, closes #38.
Philipp15b pushed a commit that referenced this issue Mar 21, 2018
@PerWiklander @Philipp15b
#36 Makes the dependency on Spyc explicit in composer.json
6f9c630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#36 Makes the dependency on Spyc explicit in composer.json PerWiklander/php-i18n
2 participants
@PerWiklander @Philipp15b