Add support for OneDrive for Business #55
Comments
|
OneDrive for Business is currently not supported. As far as I understand I need a MS subscription account just for including this feature. |
PhilippC
changed the title
|
I don't know if you need a MS subscription account. On my Windows pc I am using KeePass with the plugin "KeePass OneDrive Sync" (see https://github.com/KoenZomers/KeePassOneDriveSync). Maybe you could ask the author of this plugin, Koen Zomers, what is needed to support OneDrive for Business. |
|
I am also very interested in this. As carpac commented it is working with that plugin. I guess it is because its developer has the needed MS developer account. I would be interested in sponsoring an account for the developer of this app. Which account would be needed (individual/company) and how much would it be (region dependent, see link below)? Is that an option? https://docs.microsoft.com/sv-se/windows/uwp/publish/account-types-locations-and-fees |
|
Here is some further information, seems the client secret can be created without expiration. |
|
please use the thumbs-up reaction on the issue itself. I occasionally sort issues for this reaction when I try to decide which features will be included for the next release. |
|
Not sure what was in the deleted comments, but I was wondering if there is anything in addition to using the thumbs-up to help make this feature happen? |
|
I'm also interested in this feature. It looks like OneDrive for business needs a different authentication mechanism: And the developer needs an Office 365 subscription: https://docs.microsoft.com/en-us/onedrive/developer/rest-api/getting-started/app-registration-server?view=odsp-graph-online A developer subscription would cost 99$ per year 😢 |
|
I would be willing to donate the sub fee for this feature. I'm sure there might be a few who would also chip in for a developer o365 sub. |
|
I have purchased a Developer subscription and re-implemented OneDrive access using the new MS Graph SDK. It seems to be working for personal accounts but I can't access my OneDrive for business account, so for now that's no improvement... |
|
@kribjo please ignore my request, I think the error is more related to my app configuration than to the account. |
|
Hi Philipp, |
|
@michielhageman as you may read in the posts above yours - I am trying to do so but wasn't successful so far yet. |
|
@PhilippC thanks for your effort. This feature would be great. Currently rolled out KeePass in our company, so O4B support would be much appreciated. If you need anything let me know. |
@PhilippC So this is either an issue in your app registration (in the Microsoft App Registration Portal) or you're not using the ADALv2 authentication endpoint. I would assume it's the latter, as you're still using MS-ADAL 1.14. Have you tried the "MSA Auth For Android Adapter" with the Graph SDK already? |
|
@mplogas thanks a lot for taking a look! I am close to giving up on this, but it would be awesome if we could solve this issue and I really appreciate any help. |
|
I have a slightly different experience. Not "password is wrong" but when I try to open OneDrive for Business with an account name of x@y.onmicrosoft.com, I get "that Microsoft account does not exist" even though I can open this account on OneDrive for Android. This onmicrosoft.com domain is used when you don't want to associate your own domain with the OneDrive account. |
|
I also need this feature, as I am moving all my data from "OneDrive Personal" to "OneDrive for Business". As in the previous post: When I enter the UserID of my "OneDrive for Business" account I get the error "Account does not exist" in KeePass4Android (Apparently it only finds OneDrive Personal accounts). A short search brought me here to this topic to find out OneDrive for Business is not supported yet. Let me know if there is anything I can help with. |
|
Hello Philipc, how can i help you ? i have ent account on OneDrive for business. |
|
Hi @PhilippC |
|
+1, regarding the: "OneDrive for Business" account I get the error "Account does not exist" in KeePass4Android. |
|
I need this feature also |
|
I use this app now - for sure with some good new features. Anyway: It's not working with OneDrive for Business via the menu. I tried also using OAuth via Github but you can not add OneDrive for Business because it's not possible with work or school accounts (you get that information when you try). I think that is the problem: It's not allowed from Microsoft to authorise other Apps to access OneDrive for Business via OAuth and that's why you can't use KeePass2Android for that. I used before the KeePass2Android Offline Version and this simple works if you go to the database file in your OneDrive App and then open it with the Offline Version. If you then Open the Offline Version it automatically tries to open the database file, so you don't have to go again through the OneDrive App. THIS WORKS ALSO for the new KeePass2Android Version! So you just have to select it and then you're fine. So from my side: Problem solved in that way. |
|
@MPNeosociety I tried it. Opening is possible, but when I change something KeePaas2Android can't save it. |
No, other Apps can use Onedrive for Business via OAuth. For example, X-plore for Android works. |
|
note for myself: it looks like https://github.com/microsoftgraph/android-java-snippets-rest-sample has an up-to-date documentation on how to implement this. Will try when I'm back from my current travel. |
|
Great, wish you a good journey. |
|
I couldn't wait and installed Android Studio on a laptop I have with me. After a while I was able to find the required changes to my previous code to get this working! Finally! One thing that I would like to test/implement is working with shared files (because this currently is not working): Can anybody share a file or folder with me for testing? I'd prefer a simple text file plus a kdbx file for testing (with master password "test"). Would be great if someone could share a txt+kdbx file also with a "personal" OneDrive account (not OneDrive for business) with my personal OneDrive account: philipp.crocoll@web.de Thanks in advance! |
|
@PhilippC I've sent you an invite to a shared folder. |
|
@pstorch thanks! Unfortunately it looks like I can access the files through the browser, but I don't see them as "Shared with me" (if I click Share on the files and type my email address, it says your organization doesn't allow sharing with me). I'm not experienced with this, but it looks like there are different ways to share. I would need to see the folder in "Shared with me" to try to access it from Keepass2Android. |
|
I don't have other share options. I could share the individual files as well, but I guess this is not what we would like to test. |
|
@qj0n as I have now a first implementation of this, I would like to do some testing with using files from different accounts. I only have one, so another O365 account would be great. Can you send credentials to crocoapps@gmail.com |
|
I shared a folder with you PhilippC with OneDrive for business |
|
@PhilippC if still needed I can supply you a shared folder, both onedrive business & personal. Let me know. Really waiting for oneDrive business support :) |
|
it looks like @paololec and @pstorch have shared the folder using the "Share" button and then directly inputting my email, but this didn't work as I couldn't import the folder to my OneDrive. Maybe someone (e.g. @Mr-Pingu ) can try to click "Share" and then "Manage access", then under "Grant access" type my mail? |
|
@PhilippC I have also give you grant access. |
|
either I am doing something wrong or this does not work across domains or between your type of business accounts and my E3 developer account. Anybody with access to more than one account to test sharing internally first? |
|
@PhilippC if you have E3 developer Subscription you have 25 account with license, you can add an account in admin.microsoft.com -> active users -> add user |
|
unfortunately I have just one, but I talked to MS support and they told me how I can activate test licences. |
|
@PhilippC I could test here with two accounts within the same domain. Do you have sort an APK i could install and test? Another option would be to give you short-term access to our domain. |
|
thanks for the offer, @Mr-Pingu . But I think I will first try to work wtih the test licenses! |
|
I finally made it. Thanks for the patience, everyone :-) Here it is: Please click "Change database" (on the password screen), then "Open database", "One Drive", "All files and shared files" (or something else if appropriate) and browse to your file. Let me know if you have any trouble. |
|
Great work Philipp!
Regards,
Michiel
…________________________________
Van: PhilippC <notifications@github.com>
verzonden: vrijdag 4 oktober 2019 21:10
Aan: PhilippC/keepass2android
Cc: Michiel Hageman | Mhitz; Mention
Onderwerp: Re: [PhilippC/keepass2android] Add support for OneDrive for Business (#55)
I finally made it. Thanks for the patience, everyone :-)
Here it is:
Version 1.07b-pre2 (just published to beta, see https://play.google.com/apps/testing/keepass2android.keepass2android) has support for OneDrive for Business, but also for shared files, app folder access, multiple accounts etc.
Please click "Change database" (on the password screen), then "Open database", "One Drive", "All files and shared files" (or something else if appropriate) and browse to your file.
Let me know if you have any trouble.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#55?email_source=notifications&email_token=AKF4YXEPCXHFNYHSS5EVNO3QM6IKBA5CNFSM4D7RGQQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMT33Q#issuecomment-538525166>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKF4YXAOCXZ57YBVPILBE4DQM6IKBANCNFSM4D7RGQQQ>.
|
|
Maybe I'm doing something wrong: I don't have "Open database", but "Open file...". When I choose OneDrive there I can enter my company email, but OneDrive says "That Microsoft account doesn't exist". 🤔 |
|
You're right, it's called "Open file". If you click OneDrive, do you see the dialog to choose the variant (All files, shared files, app folder)? If not, you're probably running the old version? You can also check in app settings / about? |
|
Ah, sorry, after changing from release to the test channel I got an update on Version 1.07b-pre1 not pre2. I've now checked again and got pre2. |
When I try to open a database that is stored on OneDrive for Business, I always get a "password is wrong" error (although I am pretty sure that I typed in the correct password). Does Keepass2Android work with OneDrive for Business, too, or only with OneDrive (the "consumer" version)?
The text was updated successfully, but these errors were encountered: