Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteByQueryResponse should have failures field #2883

Closed
azolotko opened this issue Jun 30, 2023 · 2 comments · Fixed by #2896
Closed

DeleteByQueryResponse should have failures field #2883

azolotko opened this issue Jun 30, 2023 · 2 comments · Fixed by #2896

Comments

@azolotko
Copy link
Contributor

azolotko commented Jun 30, 2023 •
edited
Loading

According to Elasticsearch's documentation, DeleteByQueryResponse is supposed to have failures field, but it doesn't have one at the moment.
@azolotko
Copy link
Contributor Author

azolotko commented Jul 3, 2023

The same applies to UpdateByQueryResponse.

@sksamuel
Copy link
Collaborator

sksamuel commented Jul 9, 2023

If you have the time to make a PR, I can make the release.

azolotko pushed a commit to azolotko/elastic4s that referenced this issue Aug 7, 2023
Add failures field to UpdateByQueryResponse and `DeleteByQueryRes…
0614465 
…ponse`

Also update `ReindexResponse`
to make its `failures` field
have the same type as the one in `UpdateByQueryResponse`
and `DeleteByQueryResponse`.

Resolves Philippus#2883
@azolotko azolotko mentioned this issue Aug 7, 2023
Merged
sksamuel added a commit that referenced this issue Aug 11, 2023
@azolotko @sksamuel
Add failures field to UpdateByQueryResponse and `DeleteByQueryRes…
e2a9a5b 
…ponse` (#2896)

Also update `ReindexResponse`
to make its `failures` field
have the same type as the one in `UpdateByQueryResponse`
and `DeleteByQueryResponse`.

Resolves #2883

Co-authored-by: Alex Zolotko <oleksandr.zolotko@ibm.com>
Co-authored-by: Sam <sam@sksamuel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add failures field to UpdateByQueryResponse and DeleteByQueryResponse azolotko/elastic4s
2 participants
@azolotko @sksamuel