Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace buildBulkHttpBody-method #3105

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Replace buildBulkHttpBody-method #3105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions elastic4s-handlers/src/main/scala/com/sksamuel/elastic4s/handlers/bulk/BulkHandlers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ trait BulkHandlers {
implicit object BulkHandler extends Handler[BulkRequest, BulkResponse] {

override def build(bulk: BulkRequest): ElasticRequest = {
val httpBody: String = buildBulkHttpBody(bulk)
val httpBody: String = BulkBuilderFn(bulk).mkString("", "\n", "\n")
val entity = HttpEntity(httpBody, "application/x-ndjson")
if (logger.isDebugEnabled()) {
logger.debug("Sending bulk request")
Expand All @@ -25,12 +25,4 @@ trait BulkHandlers {
ElasticRequest("POST", "/_bulk", params.toMap, entity)
}
}

private[bulk] def buildBulkHttpBody(bulk: BulkRequest): String = {
val builder = StringBuilder.newBuilder
val rows: Iterator[String] = BulkBuilderFn(bulk)
rows.addString(builder, "", "\n", "")
builder.append("\n") // es seems to require a trailing new line as well
builder.mkString
}
}