Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DenseVectorField #3113

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Improve DenseVectorField #3113

wants to merge 10 commits into from
+141 −145

Conversation

Philippus
Copy link
Owner

Applying this PR will improve DenseVectorField, among which:

  • add element_type parameter
  • add max_inner_product similarity metric
  • introduce new apply method with proper defaults (following the documentation)
  • not set similarity if index is set to false

@Philippus Philippus requested a review from TactiC July 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TactiC TactiC Awaiting requested review from TactiC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Philippus