-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple services or characteristics with the same id #776
Conversation
6a79dc0
to
75801ca
Compare
packages/reactive_ble_mobile/ios/Classes/Plugin/PluginController.swift
Outdated
Show resolved
Hide resolved
packages/reactive_ble_mobile/ios/Classes/ReactiveBle/Central.swift
Outdated
Show resolved
Hide resolved
packages/reactive_ble_mobile/ios/Classes/ReactiveBle/Central.swift
Outdated
Show resolved
Hide resolved
packages/reactive_ble_mobile/ios/Classes/BleData extras/QualifiedCharacteristic.swift
Outdated
Show resolved
Hide resolved
faa61d4
to
5797c5f
Compare
ea79440
to
7b5fe98
Compare
...ve_ble_mobile/android/src/main/kotlin/com/signify/hue/flutterreactiveble/PluginController.kt
Show resolved
Hide resolved
7b5fe98
to
0e9bc17
Compare
@@ -152,24 +154,31 @@ open class ReactiveBleClient(private val context: Context) : BleClient { | |||
}.firstOrError() | |||
} | |||
|
|||
@SuppressLint("MissingPermission") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend against adding @SuppressLint("MissingPermission")
to the library in order to suppress lint warnings. Instead, we have provided clear instructions in the README about the required permissions for the library's proper functioning. It's important to maintain a transparent approach to permissions and ensure that developers integrating the library are aware of and handle the necessary permissions appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does adding a SuppressLint
conflict with "maintain[ing] a transparent approach to permissions and ensur[ing] that developers integrating the library are aware of and handle the necessary permissions appropriately"?
387e0cb
to
e1ed76c
Compare
packages/reactive_ble_mobile/ios/Classes/BleData extras/CharacteristicInstance.swift
Show resolved
Hide resolved
packages/reactive_ble_mobile/ios/Classes/ReactiveBle/Central.swift
Outdated
Show resolved
Hide resolved
packages/reactive_ble_mobile/ios/Classes/BleData extras/CharacteristicInstance.swift
Show resolved
Hide resolved
...ervicesWithCharacteristicsDiscovery/ServicesWithCharacteristicsDiscoveryTaskController.swift
Outdated
Show resolved
Hide resolved
packages/reactive_ble_platform_interface/lib/src/model/characteristic_instance.dart
Outdated
Show resolved
Hide resolved
213380d
to
df35339
Compare
14e6006
to
017f6ae
Compare
Hi, Sorry if this is the wrong place since it's closed, but I haven't found a place that covers this latest change and if it addresses characteristics with identical service and char uuids, but different properties (write/read/notify etc). The documentation for this package doesn't seem to cover this on pub.dev. Provided I've found the unique characteristic using the isWritable/isNotifyable fields or the instance_id, how can I get something like writeCharacteristic() or subscribeCharacteristic() to take in these unique identifiers, rather than just what the QualifiedCharacteristic object allows (only charUuid, serviceUuid, deviceId?) Is this supported in this package yet? SO post that covers this in a bit more detail: |
@castehlin The entry point for dealing with services or characteristics that don't have a unique id is |
Fixes #478
Fixes #509
The change is mostly backwards compatible. The exception to that is that if you try to use the existing read/write/subscribe methods for a characteristic ids for which there is no single unique instance, an exception is thrown. Before, it would read/write/subscribe the first matching characteristic.