connectToAdvertisingDevice: Check for recently discovered device when BLE scan already running
#875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taym95
reviewed
Jun 21, 2024
| @@ -85,7 +85,17 @@ class DeviceConnectorImpl implements DeviceConnector { | |||
| Map<Uuid, List<Uuid>>? servicesWithCharacteristicsToDiscover, | |||
| Duration? connectionTimeout, | |||
| }) { | |||
| if (_deviceScanner.currentScan != null) { | |||
| if (_deviceIsDiscoveredRecently( | |||
There was a problem hiding this comment.
why don't you just stop the scan and connect with connectToAdvertisingDevice ? why do we need this in library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents error reported in #872 as long as the device was scanned within the last
_scanRegistryCacheValidityPeriod(25 seconds) from whereconnectToAdvertisingDeviceis called. In practice, this is as good as always for usecases where a device is selected from a scan list and immediately connected.