fix(executor): fix resolving custom formatters

nx-stylelint/src/executors/lint/executor.spec.ts

@@ -130,6 +130,8 @@ describe('nx-stylelint:lint executor', () => {
     logger.error = jest.fn();
     logger.info = jest.fn();
 
+    console.warn = jest.fn();
+
     mockResult = defaultMockResult;
   });
 

nx-stylelint/src/executors/lint/executor.ts

@@ -2,9 +2,8 @@ import type { ExecutorContext } from '@nx/devkit';
 import { logger } from '@nx/devkit';
 import { existsSync, mkdirSync, writeFileSync } from 'node:fs';
 import { dirname, join } from 'node:path';
-import type { LinterResult } from 'stylelint';
-import { loadFormatter } from '../../utils/formatter';
-import { loadStylelint } from '../../utils/stylelint';
+import type { Formatter, FormatterType, LinterResult } from 'stylelint';
+import { importFormatter } from '../../utils/formatter';
 import type { LintExecutorSchema } from './schema';
 
 export async function lintExecutor(
@@ -15,9 +14,9 @@ export async function lintExecutor(
 
   let stylelint: typeof import('stylelint');
   try {
-    stylelint = await loadStylelint();
+    stylelint = await import('stylelint');
   } catch (error) {
-    logger.error(error instanceof Error ? error.message : error);
+    logger.error('Unable to find Stylelint. Please ensure Stylelint is installed.');
     return { success: false };
   }
 
@@ -30,9 +29,9 @@ export async function lintExecutor(
 
   if (!options.silent) logger.info(`\nLinting Styles "${projectName}"...`);
 
-  let resolvedFormatter;
+  let resolvedFormatter: FormatterType | Formatter;
   try {
-    resolvedFormatter = loadFormatter(options.formatter, context.cwd);
+    resolvedFormatter = await importFormatter(options.formatter);
   } catch (err) {
     logger.error(`Invalid Formatter. More Details: \n`);
     throw err;

nx-stylelint/src/generators/configuration/generator.spec.ts

@@ -42,6 +42,8 @@ describe('nx-stylelint:configuration generator', () => {
 
   beforeAll(async () => {
     logger.info = jest.fn();
+
+    console.warn = jest.fn();
   });
 
   beforeEach(async () => {

nx-stylelint/src/generators/init/generator.spec.ts

@@ -14,6 +14,8 @@ describe('nx-stylelint:init generator', () => {
 
   beforeEach(() => {
     tree = createTreeWithEmptyWorkspace({ layout: 'apps-libs' });
+
+    console.warn = jest.fn();
   });
 
   it('should add dependencies and create recommended root configuration', async () => {

nx-stylelint/src/utils/formatter.spec.ts

@@ -0,0 +1,10 @@
+import { formatters } from 'stylelint';
+import { importFormatter } from './formatter';
+
+describe('importFormatter()', () => {
+  it('should return stylelint core formatter key when given', async () => {
+    for (const formatterKey of Object.keys(formatters)) {
+      expect(await importFormatter(formatterKey)).toStrictEqual(formatterKey);
+    }
+  });
+});

nx-stylelint/src/utils/formatter.ts

@@ -1,4 +1,6 @@
-import { join } from 'node:path';
+import { existsSync } from 'node:fs';
+import { isAbsolute, resolve } from 'node:path';
+import { pathToFileURL } from 'node:url';
 import type { Formatter, FormatterType } from 'stylelint';
 import { formatters } from 'stylelint';
 
@@ -10,21 +12,14 @@ export function isCoreFormatter(formatter: unknown): formatter is FormatterType
   return formatterKeys.includes(formatter);
 }
 
-const npmPackageRegex = /^(@[a-z0-9-~][a-z0-9-._~]*\/)?[a-z0-9-~][a-z0-9-._~]*$/;
-
-export function loadFormatter(formatter: unknown, cwd: string): FormatterType | Formatter {
+export async function importFormatter(formatter: unknown): Promise<FormatterType | Formatter> {
   if (!formatter || typeof formatter !== 'string') throw new Error('Formatter must be a string!');
-  const normalizedFormatter: string = formatter.trim().replace(/\\/gu, '/');
-  if (isCoreFormatter(normalizedFormatter)) return normalizedFormatter;
+  if (isCoreFormatter(formatter)) return formatter;
 
-  const isNpmPackage = npmPackageRegex.test(normalizedFormatter);
+  let moduleOrFilePath = formatter;
+  if (existsSync(moduleOrFilePath)) moduleOrFilePath = resolve(moduleOrFilePath);
 
-  try {
-    return require(isNpmPackage ? normalizedFormatter : join(cwd, normalizedFormatter));
-  } catch (err) {
-    if (isNpmPackage && !normalizedFormatter.includes('@')) {
-      return require(join(cwd, normalizedFormatter));
-    }
-    throw err;
-  }
+  return await import(
+    isAbsolute(moduleOrFilePath) ? pathToFileURL(moduleOrFilePath).toString() : moduleOrFilePath
+  ).then((m) => m.default);
 }