Skip to content

Commit

Permalink
feat: drop support for Stylelint 15
Browse files Browse the repository at this point in the history
nx-stylelint will no longer support Stylelint v15

BREAKING CHANGE: Support for Stylelint v15 has been removed
  • Loading branch information
Phillip9587 committed Apr 11, 2024
1 parent 61f47b3 commit ba7c118
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 29 deletions.
16 changes: 16 additions & 0 deletions nx-stylelint/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,22 @@
"alwaysAddToPackageJson": false
}
}
},
"17.0.0": {
"version": "17.0.0-beta.0",
"packages": {
"stylelint": {
"version": "^16.3.1"
},
"stylelint-config-standard": {
"version": "^36.0.0",
"alwaysAddToPackageJson": false
},
"stylelint-config-standard-scss": {
"version": "^13.1.0",
"alwaysAddToPackageJson": false
}
}
}
}
}
6 changes: 3 additions & 3 deletions nx-stylelint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"tslib": "^2.6.2"
},
"peerDependencies": {
"stylelint": "^15.0.0 || ^16.0.0",
"stylelint-config-standard": ">=30.0.0",
"stylelint-config-standard-scss": ">=7.0.0"
"stylelint": "^16.0.0",
"stylelint-config-standard": ">=35.0.0",
"stylelint-config-standard-scss": ">=12.0.0"
},
"peerDependenciesMeta": {
"stylelint-config-standard": {
Expand Down
6 changes: 3 additions & 3 deletions nx-stylelint/src/executors/lint/executor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { ExecutorContext } from '@nx/devkit';
import { logger } from '@nx/devkit';
import { existsSync, mkdirSync, writeFileSync } from 'node:fs';
import { dirname, join } from 'node:path';
import type { Formatter, FormatterType, LinterResult } from 'stylelint';
import type { Formatter, FormatterType } from 'stylelint';
import { importFormatter } from '../../utils/formatter';
import type { LintExecutorSchema } from './schema';

Expand Down Expand Up @@ -52,9 +52,9 @@ export async function lintExecutor(
if (options.outputFile) {
const outputFilePath = join(context.root, options.outputFile);
mkdirSync(dirname(outputFilePath), { recursive: true });
writeFileSync(outputFilePath, 'report' in result ? result.report : (result as LinterResult).output);
writeFileSync(outputFilePath, result.report);
} else if (!options.silent) {
logger.info('report' in result ? result.report : (result as LinterResult).output);
logger.info(result.report);
}

if (totalWarnings > 0 && !options.silent) logger.warn('\nLint warnings found in the listed files.');
Expand Down
28 changes: 14 additions & 14 deletions nx-stylelint/src/generators/configuration/generator.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ describe('nx-stylelint:configuration generator', () => {
await generator(tree, defaultOptions);

const packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBeUndefined();

expect(readProjectConfiguration(tree, 'test').targets?.['stylelint']).toStrictEqual({
Expand Down Expand Up @@ -168,8 +168,8 @@ describe('nx-stylelint:configuration generator', () => {
await generator(tree, defaultOptions);

let packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBeUndefined();

expect(readProjectConfiguration(tree, 'test').targets?.['stylelint']).toStrictEqual({
Expand Down Expand Up @@ -210,9 +210,9 @@ describe('nx-stylelint:configuration generator', () => {
});

packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBe('^11.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBe('^13.1.0');

expect(readProjectConfiguration(tree, 'test2').targets?.['stylelint']).toStrictEqual({
executor: 'nx-stylelint:lint',
Expand Down Expand Up @@ -259,8 +259,8 @@ describe('nx-stylelint:configuration generator', () => {
await generator(tree, defaultOptions);

let packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBeUndefined();

expect(readProjectConfiguration(tree, 'test').targets?.['stylelint']).toStrictEqual({
Expand Down Expand Up @@ -297,8 +297,8 @@ describe('nx-stylelint:configuration generator', () => {
await generator(tree, { ...defaultOptions, project: 'test2' });

packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBeUndefined();

expect(readProjectConfiguration(tree, 'test2').targets?.['stylelint']).toStrictEqual({
Expand Down Expand Up @@ -339,9 +339,9 @@ describe('nx-stylelint:configuration generator', () => {
});

packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBe('^11.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBe('^13.1.0');

expect(readProjectConfiguration(tree, 'test3').targets?.['stylelint']).toStrictEqual({
executor: 'nx-stylelint:lint',
Expand Down
12 changes: 6 additions & 6 deletions nx-stylelint/src/generators/init/generator.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ describe('nx-stylelint:init generator', () => {
await generator(tree, defaultOptions);

const packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');

const stylelintrc = readJson<Config>(tree, '.stylelintrc.json');
expect(stylelintrc).toStrictEqual<Config>({
Expand All @@ -43,9 +43,9 @@ describe('nx-stylelint:init generator', () => {
await generator(tree, { ...defaultOptions, scss: true });

const packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^34.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBe('^11.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
expect(packagejson.devDependencies['stylelint-config-standard']).toBe('^36.0.0');
expect(packagejson.devDependencies['stylelint-config-standard-scss']).toBe('^13.1.0');

const stylelintrc = readJson<Config>(tree, '.stylelintrc.json');
expect(stylelintrc).toStrictEqual<Config>({
Expand Down Expand Up @@ -81,7 +81,7 @@ You can then migrate your custom rule configuration into the created stylelint c
);

const packagejson = readJson(tree, 'package.json');
expect(packagejson.devDependencies['stylelint']).toBe('^15.0.0');
expect(packagejson.devDependencies['stylelint']).toBe('^16.3.1');
});

it('should not add stylelint to devDependencies when present in dependencies', async () => {
Expand Down
6 changes: 3 additions & 3 deletions nx-stylelint/src/utils/versions.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Versions
export const stylelintVersion = '^15.0.0';
export const stylelintConfigStandardVersion = '^34.0.0';
export const stylelintConfigStandardScssVersion = '^11.0.0';
export const stylelintVersion = '^16.3.1';
export const stylelintConfigStandardVersion = '^36.0.0';
export const stylelintConfigStandardScssVersion = '^13.1.0';

/** Stylelint Visual Studio Code plugin identifier */
export const stylelintVSCodeExtension = 'stylelint.vscode-stylelint';

0 comments on commit ba7c118

Please sign in to comment.