Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement assertions migration #3

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

Implement assertions migration #3

wants to merge 58 commits into from

Conversation

Philzen
Copy link
Owner

@Philzen Philzen commented Jun 11, 2024 •
edited
Loading

Closes #2

Checklist

The strikethrough methods were added after TestNG v7.5.1 (the last Java 8 compatible release), therefore currently out of scope, but will be resolved via #36.

  • assertEquals[boolean arg0, boolean arg1, java.lang.String arg2]
  • assertEquals[boolean arg0, boolean arg1]
  • assertEquals[boolean arg0, java.lang.Boolean arg1, java.lang.String arg2]
  • assertEquals[boolean arg0, java.lang.Boolean arg1]
  • assertEquals[boolean[] arg0, boolean[] arg1, java.lang.String arg2]
  • assertEquals[boolean[] arg0, boolean[] arg1]
  • assertEquals[byte arg0, byte arg1, java.lang.String arg2]
  • assertEquals[byte arg0, byte arg1]
  • assertEquals[byte arg0, java.lang.Byte arg1, java.lang.String arg2]
  • assertEquals[byte arg0, java.lang.Byte arg1]
  • assertEquals[byte[] arg0, byte[] arg1, java.lang.String arg2]
  • assertEquals[byte[] arg0, byte[] arg1]
  • assertEquals[char arg0, char arg1, java.lang.String arg2]
  • assertEquals[char arg0, char arg1]
  • assertEquals[char arg0, java.lang.Character arg1, java.lang.String arg2]
  • assertEquals[char arg0, java.lang.Character arg1]
  • assertEquals[char[] arg0, char[] arg1, java.lang.String arg2]
  • assertEquals[char[] arg0, char[] arg1]
  • assertEquals[double arg0, double arg1, double arg2, java.lang.String arg3]
  • assertEquals[double arg0, double arg1, double arg2]
  • assertEquals[double arg0, double arg1, java.lang.String arg2]
  • assertEquals[double arg0, double arg1]
  • assertEquals[double arg0, java.lang.Double arg1, java.lang.String arg2]
  • assertEquals[double arg0, java.lang.Double arg1]
  • assertEquals[double[] arg0, double[] arg1, double arg2, java.lang.String arg3]
  • assertEquals[double[] arg0, double[] arg1, double arg2]
  • assertEquals[double[] arg0, double[] arg1, java.lang.String arg2]
  • assertEquals[double[] arg0, double[] arg1]
  • assertEquals[float arg0, float arg1, float arg2, java.lang.String arg3]
  • assertEquals[float arg0, float arg1, float arg2]
  • assertEquals[float arg0, float arg1, java.lang.String arg2]
  • assertEquals[float arg0, float arg1]
  • assertEquals[float arg0, java.lang.Float arg1, java.lang.String arg2]
  • assertEquals[float arg0, java.lang.Float arg1]
  • assertEquals[float[] arg0, float[] arg1, float arg2, java.lang.String arg3]
  • assertEquals[float[] arg0, float[] arg1, float arg2]
  • assertEquals[float[] arg0, float[] arg1, java.lang.String arg2]
  • assertEquals[float[] arg0, float[] arg1]
  • assertEquals[int arg0, int arg1, java.lang.String arg2]
  • assertEquals[int arg0, int arg1]
  • assertEquals[int arg0, java.lang.Integer arg1, java.lang.String arg2]
  • assertEquals[int arg0, java.lang.Integer arg1]
  • assertEquals[int[] arg0, int[] arg1, java.lang.String arg2]
  • assertEquals[int[] arg0, int[] arg1]
  • assertEquals[java.lang.Boolean arg0, boolean arg1, java.lang.String arg2]
  • assertEquals[java.lang.Boolean arg0, boolean arg1]
  • assertEquals[java.lang.Boolean arg0, java.lang.Boolean arg1, java.lang.String arg2]
  • assertEquals[java.lang.Boolean arg0, java.lang.Boolean arg1]
  • assertEquals[java.lang.Byte arg0, byte arg1, java.lang.String arg2]
  • assertEquals[java.lang.Byte arg0, byte arg1]
  • assertEquals[java.lang.Byte arg0, java.lang.Byte arg1, java.lang.String arg2]
  • assertEquals[java.lang.Byte arg0, java.lang.Byte arg1]
  • assertEquals[java.lang.Character arg0, char arg1, java.lang.String arg2]
  • assertEquals[java.lang.Character arg0, char arg1]
  • assertEquals[java.lang.Character arg0, java.lang.Character arg1, java.lang.String arg2]
  • assertEquals[java.lang.Character arg0, java.lang.Character arg1]
  • assertEquals[java.lang.Double arg0, double arg1, java.lang.String arg2]
  • assertEquals[java.lang.Double arg0, double arg1]
  • assertEquals[java.lang.Double arg0, java.lang.Double arg1, java.lang.String arg2]
  • assertEquals[java.lang.Double arg0, java.lang.Double arg1]
  • assertEquals[java.lang.Float arg0, float arg1, java.lang.String arg2]
  • assertEquals[java.lang.Float arg0, float arg1]
  • assertEquals[java.lang.Float arg0, java.lang.Float arg1, java.lang.String arg2]
  • assertEquals[java.lang.Float arg0, java.lang.Float arg1]
  • assertEquals[java.lang.Integer arg0, int arg1, java.lang.String arg2]
  • assertEquals[java.lang.Integer arg0, int arg1]
  • assertEquals[java.lang.Integer arg0, java.lang.Integer arg1, java.lang.String arg2]
  • assertEquals[java.lang.Integer arg0, java.lang.Integer arg1]
  • assertEquals[java.lang.Iterable arg0, java.lang.Iterable arg1, java.lang.String arg2]
  • assertEquals[java.lang.Iterable arg0, java.lang.Iterable arg1]
  • assertEquals[java.lang.Long arg0, java.lang.Long arg1, java.lang.String arg2]
  • assertEquals[java.lang.Long arg0, java.lang.Long arg1]
  • assertEquals[java.lang.Long arg0, long arg1, java.lang.String arg2]
  • assertEquals[java.lang.Long arg0, long arg1]
  • assertEquals[java.lang.Object arg0, java.lang.Object arg1, java.lang.String arg2]
  • assertEquals[java.lang.Object arg0, java.lang.Object arg1]
  • assertEquals[java.lang.Object[] arg0, java.lang.Object[] arg1, java.lang.String arg2]
  • assertEquals[java.lang.Object[] arg0, java.lang.Object[] arg1]
  • assertEquals[java.lang.Short arg0, java.lang.Short arg1, java.lang.String arg2]
  • assertEquals[java.lang.Short arg0, java.lang.Short arg1]
  • assertEquals[java.lang.Short arg0, short arg1, java.lang.String arg2]
  • assertEquals[java.lang.Short arg0, short arg1]
  • assertEquals[java.lang.String arg0, java.lang.String arg1, java.lang.String arg2]
  • assertEquals[java.lang.String arg0, java.lang.String arg1]
  • assertEquals[java.util.Collection arg0, java.util.Collection arg1, java.lang.String arg2]
  • assertEquals[java.util.Collection arg0, java.util.Collection arg1]
  • assertEquals[java.util.Iterator arg0, java.util.Iterator arg1, java.lang.String arg2]
  • assertEquals[java.util.Iterator arg0, java.util.Iterator arg1]
  • assertEquals[java.util.Map arg0, java.util.Map arg1, java.lang.String arg2]
  • assertEquals[java.util.Map arg0, java.util.Map arg1]
  • assertEquals[java.util.Set arg0, java.util.Set arg1, java.lang.String arg2]
  • assertEquals[java.util.Set arg0, java.util.Set arg1]
  • assertEquals[long arg0, java.lang.Long arg1]
  • assertEquals[long arg0, long arg1, java.lang.String arg2]
  • assertEquals[long arg0, long arg1]
  • assertEquals[long[] arg0, long[] arg1, java.lang.String arg2]
  • assertEquals[long[] arg0, long[] arg1]
  • assertEquals[short arg0, java.lang.Short arg1, java.lang.String arg2]
  • assertEquals[short arg0, java.lang.Short arg1]
  • assertEquals[short arg0, short arg1, java.lang.String arg2]
  • assertEquals[short arg0, short arg1]
  • assertEquals[short[] arg0, short[] arg1, java.lang.String arg2]
  • assertEquals[short[] arg0, short[] arg1]
  • assertEqualsDeep[java.util.Map arg0, java.util.Map arg1, java.lang.String arg2]
  • assertEqualsDeep[java.util.Map arg0, java.util.Map arg1]
  • assertEqualsDeep[java.util.Set arg0, java.util.Set arg1, java.lang.String arg2]
  • assertEqualsNoOrder[java.lang.Object[] arg0, java.lang.Object[] arg1, java.lang.String arg2]
  • assertEqualsNoOrder[java.lang.Object[] arg0, java.lang.Object[] arg1]
  • assertEqualsNoOrder[java.util.Collection arg0, java.util.Collection arg1, java.lang.String arg2]
  • assertEqualsNoOrder[java.util.Collection arg0, java.util.Collection arg1]
  • assertEqualsNoOrder[java.util.Iterator arg0, java.util.Iterator arg1, java.lang.String arg2]
  • assertEqualsNoOrder[java.util.Iterator arg0, java.util.Iterator arg1]
  • assertFalse[boolean arg0, java.lang.String arg1]
  • assertFalse[boolean arg0]
  • assertListContains[java.util.List arg0, java.util.function.Predicate arg1, java.lang.String arg2]
  • assertListContainsObject[java.util.List arg0, T arg1, java.lang.String arg2]
  • assertListNotContains[java.util.List arg0, java.util.function.Predicate arg1, java.lang.String arg2]
  • assertListNotContainsObject[java.util.List arg0, T arg1, java.lang.String arg2]
  • assertNotEquals[double arg0, double arg1, double arg2, java.lang.String arg3]
  • assertNotEquals[double arg0, double arg1, double arg2]
  • assertNotEquals[float arg0, float arg1, float arg2, java.lang.String arg3]
  • assertNotEquals[float arg0, float arg1, float arg2]
  • assertNotEquals[java.lang.Object arg0, java.lang.Object arg1, java.lang.String arg2]
  • assertNotEquals[java.lang.Object arg0, java.lang.Object arg1]
  • assertNotEquals[java.lang.Object[] arg0, java.lang.Object[] arg1, java.lang.String arg2]
  • assertNotEquals[java.util.Collection arg0, java.util.Collection arg1, java.lang.String arg2]
  • assertNotEquals[java.util.Collection arg0, java.util.Collection arg1]
  • assertNotEquals[java.util.Iterator arg0, java.util.Iterator arg1, java.lang.String arg2]
  • assertNotEquals[java.util.Iterator arg0, java.util.Iterator arg1]
  • assertNotEquals[java.util.Map arg0, java.util.Map arg1, java.lang.String arg2]
  • assertNotEquals[java.util.Map arg0, java.util.Map arg1]
  • assertNotEquals[java.util.Set arg0, java.util.Set arg1, java.lang.String arg2]
  • assertNotEquals[java.util.Set arg0, java.util.Set arg1]
  • assertNotEqualsDeep[java.util.Map arg0, java.util.Map arg1, java.lang.String arg2]
  • assertNotEqualsDeep[java.util.Map arg0, java.util.Map arg1]
  • assertNotEqualsDeep[java.util.Set arg0, java.util.Set arg1, java.lang.String arg2]
  • assertNotEqualsDeep[java.util.Set arg0, java.util.Set arg1]
  • assertNotNull[java.lang.Object arg0, java.lang.String arg1]
  • assertNotNull[java.lang.Object arg0]
  • assertNotSame[java.lang.Object arg0, java.lang.Object arg1, java.lang.String arg2]
  • assertNotSame[java.lang.Object arg0, java.lang.Object arg1]
  • assertNull[java.lang.Object arg0, java.lang.String arg1]
  • assertNull[java.lang.Object arg0]
  • assertSame[java.lang.Object arg0, java.lang.Object arg1, java.lang.String arg2]
  • assertSame[java.lang.Object arg0, java.lang.Object arg1]
  • assertThrows[java.lang.Class arg0, org.testng.- [ ] assert$ThrowingRunnable arg1]
  • assertThrows[org.testng.- [ ] assert$ThrowingRunnable arg0]
  • assertThrows[java.lang.String arg0, java.lang.Class arg1, org.testng.- [ ] assert$ThrowingRunnable arg2]
  • assertTrue[boolean arg0, java.lang.String arg1]
  • assertTrue[boolean arg0]
  • expectThrows[java.lang.Class arg0, org.testng.- [ ] assert$ThrowingRunnable arg1]
  • expectThrows[java.lang.String arg0, java.lang.Class arg1, org.testng.- [ ] assert$ThrowingRunnable arg2]
  • fail[]
  • fail[java.lang.String arg0, java.lang.Throwable arg1]
  • fail[java.lang.String arg0]

@Philzen Philzen force-pushed the implement-assertions-migration branch 13 times, most recently from 6394ffe to 3390454 Compare June 12, 2024 00:15
github-actions[bot]

This comment was marked as duplicate.

Sign in to view

@Philzen Philzen force-pushed the implement-assertions-migration branch from 3390454 to 4a485b0 Compare June 12, 2024 00:20
github-actions[bot]

This comment was marked as duplicate.

Sign in to view

github-actions[bot]

This comment was marked as duplicate.

Sign in to view

@Philzen Philzen force-pushed the implement-assertions-migration branch from f9366a7 to 728a38e Compare June 12, 2024 00:51
github-actions[bot]

This comment was marked as duplicate.

Sign in to view

github-actions[bot]

This comment was marked as duplicate.

Sign in to view

@Philzen Philzen force-pushed the implement-assertions-migration branch from 1ba850d to 4cd9972 Compare June 12, 2024 12:47
github-actions[bot]

This comment was marked as duplicate.

Sign in to view

@Philzen Philzen force-pushed the implement-assertions-migration branch from 4cd9972 to 08c76db Compare June 12, 2024 12:57
github-actions[bot]

This comment was marked as duplicate.

Sign in to view

github-actions[bot]

This comment was marked as duplicate.

Sign in to view

github-actions[bot]

This comment was marked as duplicate.

Sign in to view

@Philzen Philzen force-pushed the implement-assertions-migration branch from 99cab2e to 2a5a60b Compare June 12, 2024 13:16
github-actions[bot]

This comment was marked as duplicate.

Sign in to view

@Philzen Philzen force-pushed the implement-assertions-migration branch 2 times, most recently from 6fc779e to ba5bd70 Compare June 12, 2024 19:16
@Philzen Philzen force-pushed the main branch 30 times, most recently from d7e746f to d606f71 Compare June 24, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
TestNG → Jupiter
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement migration of assertions
2 participants
@Philzen @MBoegers