Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge DataProvider migration recipe from MBoegers/migrate-testngtojupiter-rewrite #38

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

Merge DataProvider migration recipe from MBoegers/migrate-testngtojupiter-rewrite #38

wants to merge 51 commits into from

Commits on Jun 22, 2024

  1. Add TestNG dependency, so it is available on the classpath for tests

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c4846ab View commit details
    Browse the repository at this point in the history

  2. Implement TestNG → JUnit5 @test annotation migration recipe with tests 

    Resolves #17, #19 and #26
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    09d1ee0 View commit details
    Browse the repository at this point in the history

  3. Fix extraneous import added when all usages are fully qualified

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a94d4f3 View commit details
    Browse the repository at this point in the history

  4. Implement migration of expectedExceptionsMessageRegExp annotation att… 

    …ribute

Resolves #22
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    19b3099 View commit details
    Browse the repository at this point in the history

  5. Implement migration of TestNG enabled = false to Junit5 @disabled 

    Resolves #18
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2f74be1 View commit details
    Browse the repository at this point in the history

  6. Add general introductory text and Java 8 compatiblity badge

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    d939333 View commit details
    Browse the repository at this point in the history

  7. Implement migration of TestNG @test(description) to Junit5 @DisplayName 

    Resolves #24
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0b63586 View commit details
    Browse the repository at this point in the history

  8. Implement migration of TestNG @test(groups) to Junit5 @tag 

    Resolves #28
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b2b006e View commit details
    Browse the repository at this point in the history

  9. Remove samples content

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    63a3572 View commit details
    Browse the repository at this point in the history

  10. Add build & usage writeup and remove unrelated content from template

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    48532bf View commit details
    Browse the repository at this point in the history

  11. Add rewrite-testing-frameworks dependency (enables official recipes) 

    Makes official org.openrewrite.java.testing.* recipes available for
usage in our own master recipe.
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f78a1a8 View commit details
    Browse the repository at this point in the history

  12. Cook up basic recipe list including testing.junit5.AddMissingNested

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    e57948c View commit details
    Browse the repository at this point in the history

  13. Set up code coverage statistics

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    374cf3d View commit details
    Browse the repository at this point in the history

  14. [CI] Run Jacoco during mvn verify and upload XML output as artifact

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    dcb19b1 View commit details
    Browse the repository at this point in the history

  15. [CI] Activate dedicated Sonar GitHub action

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    855a52d View commit details
    Browse the repository at this point in the history

  16. Include code coverage badge

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    3ec4c6b View commit details
    Browse the repository at this point in the history

  17. Make java parser instantiation thread safe and move to utils class

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    474c292 View commit details
    Browse the repository at this point in the history

  18. Put common constant strings into static final variables

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    470db0f View commit details
    Browse the repository at this point in the history

  19. Factor out post visitCompilationUnit visitor

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    3059a88 View commit details
    Browse the repository at this point in the history

  20. Always modify instead of creating new when annotation type J.FieldAccess 

    Annotation type is J.FieldAccess anytime the annotation is fully qualified.
The code in org.openrewrite.java.testing.junit5.UpdateTestAnnotation
(which this is based on) would build a new annotation instance instead of
modifying the type of the existing annotation. It turns out the latter also
works fine for this recipe's scope.
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4eaf295 View commit details
    Browse the repository at this point in the history

  21. Implement migration of class-level @Test annotation to methods 

    Resolves #16
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    79bb143 View commit details
    Browse the repository at this point in the history

  22. Replace GitHub and SonarCloud badges with shields.io

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ff1d555 View commit details
    Browse the repository at this point in the history

  23. Move maven build action into Analyze workflow 

    SonarCloud depends on the jacoco XML to be produced, but will be
started before it is uploaded on PRs, thus failing. Moving the
maven build action into that workflow reduces the overall build
time as maven and gradle build can run in parallel.
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    305e89b View commit details
    Browse the repository at this point in the history

  24. Add list of annotation attributes that cannot be migrated (yet)

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c751669 View commit details
    Browse the repository at this point in the history

  25. Avoid 'File encoding has not been set' maven warning, defining UTF-8

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ed8c4f6 View commit details
    Browse the repository at this point in the history

  26. Factor out complex J.* operations into Util classes

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    d89aaf1 View commit details
    Browse the repository at this point in the history

  27. Remove redundant checks and return early wherever feasible

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bc3ebcf View commit details
    Browse the repository at this point in the history

  28. Move repetitive Comparator declarations into Util class

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c583f94 View commit details
    Browse the repository at this point in the history

  29. Improvements on the template for maven users (#56) 

    * Improvements on the template for maven users

Signed-off-by: Adriano Machado <60320+ammachado@users.noreply.github.com>

* Minor touch ups

---------

Signed-off-by: Adriano Machado <60320+ammachado@users.noreply.github.com>
Co-authored-by: Tim te Beek <tim@moderne.io>
    @ammachado @timtebeek @Philzen
    2 people authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    68f70fe View commit details
    Browse the repository at this point in the history

  30. Disable process-sources:copy goal

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    3585aaf View commit details
    Browse the repository at this point in the history

  31. Add tests and dependency for Data Provider migration

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ac7b188 View commit details
    Browse the repository at this point in the history

  32. Implement data provider migrations

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    98177a0 View commit details
    Browse the repository at this point in the history

  33. Fix licence headers

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    12f6372 View commit details
    Browse the repository at this point in the history

  34. Add Search Visitors for annotation usage

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    58c0050 View commit details
    Browse the repository at this point in the history

  35. Use preconditions and annotation search

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    acb321d View commit details
    Browse the repository at this point in the history

  36. Introduce search visitor for Annotation and helper to extract annotat… 

    …ion parameter value
    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f5e4fb2 View commit details
    Browse the repository at this point in the history

  37. Refactor to use helpers

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    58a0641 View commit details
    Browse the repository at this point in the history

  38. remove unused method

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ae36444 View commit details
    Browse the repository at this point in the history

  39. Move DataProvider recipe one package-level and rename helper 

    Retaining git commit history by doing this in a separate step
    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    423b1e2 View commit details
    Browse the repository at this point in the history

  40. Refactor MigrateDataProvider recipe, add javadoc to utilities

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    e70bbbb View commit details
    Browse the repository at this point in the history

  41. Apply best practices

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    d2e4e0b View commit details
    Browse the repository at this point in the history

  42. add packages to test files to fix import order

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    13f1a8d View commit details
    Browse the repository at this point in the history

  43. apply best practices

    @MBoegers @Philzen
    MBoegers authored and Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bf07f9c View commit details
    Browse the repository at this point in the history

  44. Introduce JDK 8 compatibility

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    7994e9e View commit details
    Browse the repository at this point in the history

  45. Make inner classes static

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    942895d View commit details
    Browse the repository at this point in the history

  46. Fix trailing whitespace in text blocks

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4c5fc0f View commit details
    Browse the repository at this point in the history

  47. Fix typos and remove undocumented JavaDoc tags

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    34390f1 View commit details
    Browse the repository at this point in the history

  48. Remove unused methods

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    c098fa7 View commit details
    Browse the repository at this point in the history

  49. Convert helper class to non-instantiable enum utility class

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    27d4d09 View commit details
    Browse the repository at this point in the history

  50. Apply finality to variables and return early where appropriate

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a72cc39 View commit details
    Browse the repository at this point in the history

  51. Add MigrateDataProvider to recipe list

    @Philzen
    Philzen committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    20f672e View commit details
    Browse the repository at this point in the history