Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update CDN links #106

Merged
merged 2 commits into from Nov 13, 2020
Merged

Fix: Update CDN links #106

merged 2 commits into from Nov 13, 2020

Conversation

Phixyn
Copy link
Owner

@Phixyn Phixyn commented Nov 13, 2020

Pull Request Submission

Thank you for taking the time to contribute to this project! Please take the time to tell us a bit about the changes you've made.

Description

Give a short and brief description of the pull request. Add a screenshot if appropriate and helpful. Changes can be listed in the next section.

Updates CDN links to be HTTPS links. Closes #105.

Changes

List the changes made.

  • Updated social media preview image links to be HTTPS links

Breaking Change?

Will these changes cause existing functionality to not work as expected? Will contributors be able to run the project after these changes are merged, without needing to take any additional steps?

  • Please tick if this is a breaking change and describe why below

Merging Checklist

Lastly, before merging we need to make sure that these are done.

  • Project builds and runs
  • All changes were tested
  • All tests are up-to-date
  • All tests pass
  • Code style follows current style guide
  • Code documentation is up-to-date
  • Project documentation is up-to-date

@Phixyn Phixyn added bug Something is broked pls fix critical Something is very critically broken labels Nov 13, 2020
@Phixyn Phixyn added this to the v1.1.1 milestone Nov 13, 2020
@Phixyn Phixyn added this to In progress in No BS Looper - Sprint 3 via automation Nov 13, 2020
@Phixyn Phixyn merged commit dddf5ce into master Nov 13, 2020
No BS Looper - Sprint 3 automation moved this from In progress to Done Nov 13, 2020
@Phixyn Phixyn deleted the fix/update-cdn-links branch November 13, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something is broked pls fix critical Something is very critically broken
Projects
No open projects
No BS Looper - Sprint 3
  
Done
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Update CDN links to use HTTPS
1 participant
@Phixyn