Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an aspect ratio prop to Carousel component #116

Open
Phixyn opened this issue Oct 19, 2020 · 0 comments
Open

Add an aspect ratio prop to Carousel component #116

Phixyn opened this issue Oct 19, 2020 · 0 comments
Labels
buefy UI work using the Buefy framework improvement An improvement for an existing feature ui User Interface

Comments

@Phixyn
Copy link
Owner

Phixyn commented Oct 19, 2020

The Carousel should have an aspect ratio prop that can be passed to it. Then, on the CMS, we could include the aspect ratio of images expected to be in the carousel. In the carousel component, we would use the aspect ratio to add a Bulma class to the figure element:

<figure class="image is-5by3">

There might be a problem if we want to use images with different aspect ratios in a single carousel. In that case, we might have to crop images or resize them accordingly.

See also: https://bulma.io/documentation/elements/image/#responsive-images-with-ratios

@Phixyn Phixyn added improvement An improvement for an existing feature ui User Interface buefy UI work using the Buefy framework labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buefy UI work using the Buefy framework improvement An improvement for an existing feature ui User Interface
Projects
None yet
Development

No branches or pull requests

1 participant