Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary title attributes #141

Merged
merged 2 commits into from Nov 16, 2020
Merged

Conversation

Phixyn
Copy link
Owner

@Phixyn Phixyn commented Nov 16, 2020

Pull Request

Description

Give a short and brief description of the pull request. Add a screenshot if appropriate.

Title attributes that didn't add any value to their elements (e.g. just repeating the link text) have been removed. Same for some figure elements.

Changes

List the changes made.

  • Removed unnecessary title attributes from links
  • Removed title attribute from project page's carousel figure element (keeping the ones in the indicators)
  • CMS: Removed unnecessary title attributes from various links in content pages like "About" and homepage

Breaking Change?

Will these changes cause existing functionality to not work as expected? Will contributors be able to run the project after these changes are merged, without needing to take any additional steps?

  • Tick if this is a breaking change and describe why below

Merging Checklist

Lastly, before merging we need to make sure that these are done.

  • Project builds and runs
  • All changes were tested
  • All tests are up-to-date
  • All tests pass
  • Code style follows the JavaScript and Vue.js style guides
  • Code documentation is up-to-date
  • Project documentation is up-to-date

@Phixyn Phixyn added improvement An improvement for an existing feature ui User Interface labels Nov 16, 2020
@Phixyn Phixyn added this to the v1.0.1 milestone Nov 16, 2020
@Phixyn Phixyn added this to In progress in Redhawk - Sprint 7 via automation Nov 16, 2020
@Phixyn Phixyn merged commit d446ca7 into master Nov 16, 2020
Redhawk - Sprint 7 automation moved this from In progress to Done Nov 16, 2020
@Phixyn Phixyn deleted the 125/remove-title-from-links branch November 16, 2020 21:50
@Phixyn Phixyn linked an issue Nov 16, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement for an existing feature ui User Interface
Projects
Development

Successfully merging this pull request may close these issues.

Remove "title" attribute from most links
1 participant