Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Attempt to weaken radside desync #1255

Merged
merged 2 commits into from
May 8, 2024
Merged

[Minor] Attempt to weaken radside desync #1255

merged 2 commits into from
May 8, 2024

Conversation

chaserli
Copy link
Contributor

@chaserli chaserli commented May 8, 2024

No description provided.

@github-actions github-actions bot added the Minor Documentation is not required label May 8, 2024
@chaserli chaserli added the Phobos bug Something isn't working properly label May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Starkku
Starkku requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Starkku Starkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the fix, it eradicated the reproducible desync I had with RadSites. Couple of possible minor nitpick changes I guess.

src/Ext/RadSite/Hooks.cpp Outdated Show resolved Hide resolved
src/Ext/RadSite/Hooks.cpp Show resolved Hide resolved
src/Ext/RadSite/Hooks.cpp Show resolved Hide resolved
src/Ext/Side/Body.cpp Show resolved Hide resolved
src/Ext/WarheadType/Detonate.cpp Show resolved Hide resolved
@Metadorius Metadorius merged commit 79c0ade into Phobos-developers:develop May 8, 2024
6 checks passed
@chaserli chaserli deleted the fix-rad-desync-0 branch May 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starkku Starkku Starkku approved these changes

Assignees
No one assigned
Labels
Minor Documentation is not required Phobos bug Something isn't working properly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chaserli @Starkku @Metadorius