Customizable Rocker Amplitude & Wake Anim #1258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # YRpp
…-request # Conflicts: # docs/Whats-New.md
Metadorius
approved these changes
May 14, 2024
src/Ext/TechnoType/Body.h
Outdated
Comment on lines
194
to
195
| Valueable<AnimTypeClass*> Wake; | ||
|
|
There was a problem hiding this comment.
Wouldn't it be better to use Nullable here too?
chaserli
requested changes
May 14, 2024
I already merged the latest dev and fixed the build. |
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
FS-21
reviewed
May 18, 2024
# Conflicts: # docs/Whats-New.md # src/Ext/TechnoType/Body.cpp # src/Ext/TechnoType/Body.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help TwinkleStar to finish his 2 pull requests, with proper docs this time
#1080
#1082
The rocker amplitude of warheads with
Rocker=yesused to be determined byDamagevalue of the weapon. You can now specify it separately.In
rulesmd.ini:You can now specify the
Wakeanim per TechnoType to override default rules value.In
rulesmd.ini: