-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizable Rocker Amplitude #1258
Customizable Rocker Amplitude #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No complaints about code style, probably would be better to use Nullable here tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently you missed the wakes for squids and crashed units.
rebase/force push the branch plz
Do not abuse sanity check when it's pointless
I already merged the latest dev and fixed the build. |
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
0c54851
to
0f3ef3d
Compare
TwinkleStar has completed the customized wake settings for Squid parasite and sinking as well In [SOMETECHNO] ; TechnoType
Wake.Grapple= ; Anim (played when Techno being parasited on the water), default to [General] Wake
Wake.Sinking= ; Anim (played when Techno sinking), default to [General] Wake |
0f3ef3d
to
e6aae50
Compare
fe1d4d6
to
00c975e
Compare
Took the liberty of splitting off mergeable changes and merging them with correct credit. As for the [SOMEWH] ; WarheadType
Rocker.AmplitudeMultiplier=1.0 ; float
Rocker.FixedAmplitude= ; integer The first tag would multiply the regular damage if the user wants it to scale with damage, the second one would just override the damage with a fixed one. Also better naming. |
GH screw off, I didn't want to close this |
3b64011
to
e6bcc12
Compare
e6bcc12
to
9ad13db
Compare
Co-authored-by: Coronia <2217891145@qq.com>
9ad13db
to
488a1b7
Compare
added the suggested change. The second tag is named as Rocker.AmplitudeOverride |
Help TwinkleStar to finish his pull request, with proper docs this time
#1080
The rocker amplitude of warheads with
Rocker=yes
used to be determined byDamage
value of the weapon. You can now override it with another fixed value or add a mutiplier to it.In
rulesmd.ini
: