Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strafing.Shots > 5 #1275

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Strafing.Shots > 5 #1275

merged 2 commits into from
Jun 24, 2024

Conversation

chaserli
Copy link
Contributor

@chaserli chaserli commented Jun 1, 2024

Now works with any projectile (no longer requires ROT <=1)

Copy link

github-actions bot commented Jun 1, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@Starkku Starkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strafing.Shots should not control whether or not the attack is strafing, it should logically be separated to a different key, probably called just Strafing=bool. Strafing.Shots just controls how many times it fires, you might want to make a strafing weapon that isn't ROT < 2 and not change that and Phobos should intuitively support that.

Some code style nitpicks as well.

src/Ext/Techno/Body.h Outdated Show resolved Hide resolved
src/Ext/Aircraft/Hooks.cpp Outdated Show resolved Hide resolved
src/Ext/Aircraft/Hooks.cpp Outdated Show resolved Hide resolved
@Starkku
Copy link
Contributor

Starkku commented Jun 24, 2024

Tested and it works fine. Took a liberty of fixing some minor code style issues and updating YRpp with better definitions for the unknown AircraftClass fields as well as adjusting couple of things in the documentation (this isn't really a Phobos bug fix). Merging since it is more or less complete.

@Starkku Starkku merged commit d1a0b2f into Phobos-developers:develop Jun 24, 2024
6 checks passed
@chaserli chaserli deleted the strafing branch June 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants