Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script action for repairing destroyed bridges #791

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Script action for repairing destroyed bridges #791

wants to merge 21 commits into from

Conversation

FS-21
Copy link
Contributor

@FS-21 FS-21 commented Nov 8, 2022 •
edited

  • Picks a Bridge Repair Hut from the map that is linked with a bridge with destroyed sections and is reachable by engineers and then send the Taskforce against it.
  • The Taskforce must have any engineer and (Bridge Repair Huts in the map) or the script will end.
  • Puts non-engineers into Area Guard mode when they arrive near the Bridge Repair Hut location.
  • Only are evaluated Bridge Repair Huts that can be reached by the Engineers.

In aimd.ini:
[SOMESCRIPTTYPE] ; ScriptType
x=10105,n ; integer, mode for selecting Bridge Repair Huts

  • The possible argument values are:
    0 -> Pick the closest
    1 -> Pick the Farthest
    -1 -> Pick Random

@FS-21
initial commit
5bc8b33
@FS-21
Point to the desired YRpp
5915c35 
With the Bridge validation check
@FS-21
Improvements and additions
287c07b 
Now the script action argument can be used to select a mode:
0: Closest Repair Hut with destroyed bridge.
1: Farthest Repair Hut with destroyed bridge.
-1: Random Repair Hut with destroyed bridge.

Important: now Engineers will pick only Repair Huts that can be reached.
@FS-21
Point to latest YRpp with the required change
6cdb227
@FS-21
Script action renaming and docs
e016d41 
Now is the action 10104 and added documentation.
@FS-21
Merge remote-tracking branch 'origin/develop' into feature/script-act…
8b2da26 
…ion-repair-destroyed-bridge
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Nightly build for this pull request:

chaserli
chaserli reviewed Jan 16, 2023
View reviewed changes
src/Ext/Script/Body.cpp Outdated Show resolved Hide resolved
@Starkku Starkku force-pushed the develop branch 2 times, most recently from aae92fd to a32076e Compare June 3, 2023 10:14
@FS-21
Copy link
Contributor Author

FS-21 commented Sep 29, 2023

Internal rewrite of the feature.

Thanks to Starkku I don't need to do a pathfinding routine, simplifying the code doing the same.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2024

Warning

Rate Limit Exceeded

@FS-21 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 13 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between eef9bc0 and ba9f42b.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaserli chaserli chaserli left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FS-21 @chaserli @Belonit