Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setpack subchannel to allow a pack to be set for a player from a … #18

Closed
wants to merge 1 commit into from

Conversation

bundabrg
Copy link

@bundabrg bundabrg commented Sep 4, 2018

Closes #17

Add's a subchannel 'setpack' with parameters:

  • player_uuid
  • pack_name

Requires a plugin on a backend server to make use of it. I whipped up a very quick and dirty plugin at https://github.com/bundabrg/BungeeResourcesHack that allows a console user to use the command '/gusepack'.

@Phoenix616
Copy link
Owner

Generally speaking I don't have anything against such a feature but I would like to suggest some improvements:

  • Use the same format like in the other channel (so setPack)
  • Make it possible to set the pack temporary (or not) with a parameter (if missing should default to the server's setting in the config)
  • Either add a parameter or a separate sub-channel (sendPack) to differentiate between just setting the pack in the storage and actually sending it to the player
  • Add a API method on the Bukkit-side for sending this plugin message so that plugins can just use that instead of having to manually send the plugin message and potentially running into issues when the plugin's message channel specification changes

Also please pull the changes that I made to the repository since you forked. That includes an added license-file (GPLv3) which wasn't quite clear before that addition. In order to be sure that you accept the terms of the license and that your code is licensed under that it would be good if that your PR includes that.

@bundabrg
Copy link
Author

I might close this since I totally forgot about it.

@bundabrg bundabrg closed this Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API to set ResourcePermanently from Server
2 participants