Move constants to variables or admin settings

[Phorum]

would it be an idea to move the settings-like constants to the admin for 5.3?
And only keep real constants in there. Or at least change them into variables instead of constants if they are considered special. That way they can still be overridden from a module. Now admins have to edit the constants.php file after each upgrade.

Reported by: mmakaay
Imported from TRAC: http://trac.phorum.org/ticket/680

[Phorum]

I think these can go into the admin.
{{{
define("PHORUM_MAX_READ_COUNT_PER_FORUM", 1000);
define("PHORUM_MOD_EMAIL_VIEW", true);
define("PHORUM_MOD_IP_VIEW", true);
define("PHORUM_DELETE_CHANGE_AUTHOR", true);
define("PHORUM_ENFORCE_UNREGISTERED_NAMES", true);
define("PHORUM_SEPARATOR", " :: ");
}}}
These are still constants in my mind:
{{{
define("PHORUM_FILE_EXTENSION", "php");
define("PHORUM_MAX_EDIT_TIME", 86400);
define('PHORUM_CACHE_DEFAULT_TTL', 3600);
define('PHORUM_CACHE_SPLIT',4);
define('PHORUM_BADWORD_REPLACE', '@#$%&');
define('PHORUM_DEFAULT_TEMPLATE', 'emerald');
define('PHORUM_DEFAULT_LANGUAGE', 'english');
}}}

By: brian

[Phorum]

Agreed, except for PHORUM_BADWORD_REPLACE. People might want to replace bad words by other code like [censored] or beeeeeep (and I've seen people do it).

By: mmakaay