Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Resize Image” incorrectly calculates the aspect ratio #203

Closed
bmyagkov opened this Issue Mar 6, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@bmyagkov
Copy link

bmyagkov commented Mar 6, 2019

Description
The tool incorrectly calculates aspect ratio even with the “preserve aspect ratio” button checked and as a result the image loses its original proportions

Severity: high
Repeatability: stable

Steps to reproduce

  1. Start the program
  2. Create new image with 1024 height and 768 width
  3. Open “Image Size” from top menu
  4. Make sure “Preserve aspect ratio” checked
  5. Change width to 500, height will automatically set to 400
  6. Press “OK” to confirm

Actual result
Image will resizes to 500x400 from 1024x768 as promised in the resize window

Expected Result
The correct value should be 500x375 which will preserve the correct aspect ratio and will not distort the original image

Environment
Windows 10 LTSC x64
Windows 7 Professional x64
Ubuntu 18.04.2 LTS x64
PhotoFlare 1.5.7
14

@DylanC DylanC added the bug label Mar 6, 2019

@DylanC

This comment has been minimized.

Copy link
Contributor

DylanC commented Mar 6, 2019

@bmyagkov - Previously I put in a fix for Resize image but that upset behaviour for new images. Now we have a problem with Resize again after putting in fix for new images. 😐

@DylanC

This comment has been minimized.

Copy link
Contributor

DylanC commented Mar 8, 2019

@bmyagkov - I have a fix pushed in for this now. Initial testing shows good results and fixes your issue. I will do some more testing before I consider it fixed.

@DylanC

This comment has been minimized.

Copy link
Contributor

DylanC commented Mar 8, 2019

@bmyagkov - Its possible to check this via the AppImage on Linux if you want.
https://github.com/PhotoFlare/photoflare/releases/tag/continuous

Fix will be in the next release. (very soon)

@DylanC DylanC closed this Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.