Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Compiler Warning - multiple Umbrella headers for module 'PhotoPay' missing #8

Open
icappsCedric opened this issue Jan 17, 2024 · 5 comments

Comments

@icappsCedric
Copy link

Hi,

We are trying to get the new photopay 9.0.0 framework inside our app, but I keep getting multiple errors:
Screenshot 2024-01-16 at 14 18 20

I tried to add these imports in the Photopay.h file (as specified by you guys in a closed issue #6), but after building it, the imports seem to be removed. Can you please add them to the file.

Another small remark on my end: When unpacking the new 9.0.0 framework, it actually misses the Photopay.framework map, it only shows the internal maps + the file size has gone down from 400MB to about 100MB. Is this actually normal? Because the release notes don't really specify anything on it.

@MBrizic01
Copy link

Hello @icappsCedric. We removed these headers from v8.0.0 as we changed the original PhotoPay SDK. The SDK now includes only PhotoPay and BlinkInput recognizers for scanning payment slips and payment barcodes. You can read more about it here. For BlinkID recognizers and identity document scanning, please import BlinkID SDK. As for your last question, if you still wish to use PhotoPay SDK, once you download v9.0.0, you need to rename "PhotoPay-ios-v9.0.0" into "PhotoPay.xcframework" and import it into the project. For any other questions, you can reach out to support@microblink.com

@icappsCedric
Copy link
Author

Hi,

As far as I can see, these headers were not removed. See screenshot for example. They are still inside the 9.0.0 project we got from your end.

Screenshot 2024-01-17 at 13 57 39

@MBrizic01
Copy link

Hi @icappsCedric, we wanted to remove these headers and leave only PhotoPay and BlinkInput recognizers for scanning payment slips and barcodes. However, in a big refactoring, it is possible that we skipped some things, but the new release is coming this quarter, and we will do additional checks to avoid this kind of situation. That being said, we have no issues in building this version. Are you treating warnings as errors? This could explain the problem. For now, we would ask you to change this setting, and we will make improvements in our next release.

@icappsCedric
Copy link
Author

We did this for now (treating warning as errors) but PLEASE fix this for the 9.1
I just read the release notes and in the bugs, there is nothing about fixing it..

@somyaguptagit
Copy link

Hi @icappsCedric We would kindly ask you to test out the latest release and let us know if everything works as expected.
https://github.com/PhotoPay/photopay-ios/blob/master/Release%20notes.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants