Show frame over the preview #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi34
requested changes
Sep 29, 2022
andi34
force-pushed
the
dev
branch
3 times, most recently
from
22e4335
to
b6ba3b8
Compare
andi34
reviewed
Sep 30, 2022
andi34
approved these changes
Oct 3, 2022
andi34
force-pushed
the
dev
branch
3 times, most recently
from
3023c3c
to
e9ad0eb
Compare
up-87
approved these changes
Nov 28, 2022
|
I'll repush and merge later in the evening or tomorrow morning |
…der certain conditions Change-Id: Id3e92810b4459214bad2652074920b61bd862ea4
Change-Id: I48a678ac3928f9420209fe3fa9fdf2ccb0506a0f
Change-Id: Iefab2b7fd9763d9318b84e6ec22fe7b5da39b343
…down Change-Id: I2b19454d269f1d474f6bbccae296269b76b87180
…to the real dimensions of the live preview Change-Id: I0a697420b7d7bae7baf43a89ea3a7b307e31586b
…ject-fit Change-Id: I892f1a9f8fefed699679389633dd3492772d8c5d
Change-Id: I90437e7ce2d7d6d5109664bdff1ca003552e28cb
Change-Id: Ie580a96d4be43f7a3673cd951efa95962ba3084c
Formatting hmtl code is not setup yet. Change-Id: I70cafab0edde056cb83de4177d6e1112f6cdc402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
This new feature allow the guests to see themselves on the live preview with the frame on top so they can positionate according to it.
The frame is shown on both picture and collage if they have the option enabled (in the case of collage has to be "always").
The other restriction is that the preview has to be in a "contain" object-fit to maintain the proportion of both preview and frame.
Is there anything you'd like reviewers to focus on?
I'm sorry for the commit messages!