Improve preview handling #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess flickering and more stable
…tton Change-Id: I42ce798730cf564256be1e24dd9856b2ecaeb02d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What started as a bugfix ended up as an improvement / rework. The change from preview to countdown failed for me at times without reason. I reworked it to use the same preview. As you can only define one preview source there's no reason to restart the preview and display the video on another element. This removes some flicker on the countdown press and is more reliable.
Also fixed that the countdown to stop the video was off by 1 and I only stop the video if a killcmd was defined.
What changes did you make? (Give an overview)
video--view and video--preview became one. I have to shift the z-index and change some background transparency to show / hide other elements.
Is there anything you'd like reviewers to focus on?
Because of my given setup I was only able to test the new preview setup with gphoto2 / cameracontrol.py preview - with and without background preview. This should be verified on distinct setups.