Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: api, also improve random image naming #87

Merged
merged 2 commits into from Nov 22, 2022
Merged

cleanup: api, also improve random image naming #87

merged 2 commits into from Nov 22, 2022

Conversation

andi34
Copy link
Contributor

@andi34 andi34 commented Nov 22, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain: remove unused code, use microtime instead time to get a random image name

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

This gives a more random name, just in case a random name is needed
within short time.

Change-Id: Ie0228b98095fc94113b88f53621ec967e16d3068
Without a real database it's complicated to get a real number.
If an image is deleted, other images might get overridden because
the next number might exist already.

Change-Id: I96c93ef2795e6d82cc3f06c477c7e2f763d8e610
@andi34 andi34 merged commit 224c9e7 into dev Nov 22, 2022
@andi34 andi34 deleted the cleanup/api branch November 22, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant