Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where did max error bits > 7 recommendation come from? #1369

Open
sciencewhiz opened this issue Jan 14, 2024 · 2 comments
Open

Where did max error bits > 7 recommendation come from? #1369

sciencewhiz opened this issue Jan 14, 2024 · 2 comments

Comments

@sciencewhiz
Copy link

The docs recommend max error bits > 7 for tag family 36h11. However, the official AprilTag library does not support values >3. https://github.com/AprilRobotics/apriltag/blob/4a689cc13cfe1f3b31f7ea6f07575364e65b2c90/apriltag.c#L261-L267

Where did this recommendation come from?

https://docs.photonvision.org/en/latest/docs/apriltag-pipelines/2D-tracking-tuning.html#max-error-bits

@sciencewhiz
Copy link
Author

Additionally, was memory taken into account with this recommendation? This implies that memory usage grows very quickly with more error bits corrected.

AprilRobotics/apriltag_ros#73

The memory consumption is essentially O(n choose k) == O(n!/(k! * (n-k)!)) where n is the number of tags in the family and k is whatever you set the number of bits to (as long as k << n).

A practical example, although with a bigger n here: AprilRobotics/apriltag_ros#93 (comment)

@mdurrani808
Copy link
Contributor

It was just from testing if i remember correctly. This is the only message that I can find to back it up https://discord.com/channels/725836368059826228/725848198794706994/1040671053451644978.

If you could submit an issue over to the main repo to cap things at 3 and we'll change this recommendation.

@mdurrani808 mdurrani808 transferred this issue from PhotonVision/photonvision-docs Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants