Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

"Leadership XP" is broken #39

Closed
Phr33d0m opened this issue Jan 28, 2015 · 2 comments
Closed

"Leadership XP" is broken #39

Phr33d0m opened this issue Jan 28, 2015 · 2 comments

Comments

@Phr33d0m
Copy link
Owner

Hi, there are lots of places in the code where we check vs. "Leadership" to do stuff. Now we have "Leadership XP" which won't match and the bot won't do lots of necessary stuff for that profession.

I do want to have the two different task lists but not the way it is now (like different professions).

Something like the following should we way better IMHO:

$Leadership = {all the AD oriented tasks};
$LeadershipXP = {all the XP oriented tasks};

if(user wants AD)
    definedTask["Leadership"] = $Leadership;
else if(user wants XP)
    definedTask["Leadership"] = $LeadershipXP;

And somewhere a checkbox or a switch so we know what the user wants.

@noonereally
Copy link
Collaborator

The check vs Leadership is for taskName and not taskListName, both those tasks are of the same 'type'
and leadership xp should pass all those checks.

I'm using it right now and it works as it should and not broken, it does all the necessary stuff including buying assets / tools

If you find anything specific that does not work, please post

The 'if' above will probably not work because it will set it globally and not per char.
I've posted a semi-working/concept solution in the #40 discussion.

@Phr33d0m
Copy link
Owner Author

You're right, just double-checked that it uses indeed taskName... it was late the other night and I saw taskListName a couple of times but that does a completely different thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants