-
Notifications
You must be signed in to change notification settings - Fork 31
Fixed for wrong recursive profiles adding for custom profiles #122
Conversation
update to latest
see comment in Phr33d0m#116
There is a difference in expected behavior. This fix so far fixes issue above while with custom profiles while issue with regia remains. at lvl 25 we get not recursive list profession. My changes are following - for custom profiles unless specified - set recursive to false.
if somebody can make it sufficient simpler you are welcome. For now this one works for me. |
I am really not sure how we add profiles. How I see it the main issue is profile clutter, and long repetitive profiles. The order of those operations matter greatly, and as i see it, it should be expand and later override. Then it can override a base profile if needed. I don't know if this is what called recursive? There was another suggestion to add the former line to the current one (even if both not empty). In any case, I think that all the profiles that come out of addProfile function must be complete with all levels and all flags so a later addProfile can use them as base. I apologize if I wrote things that seems trivial, but I want to confirm that I understand correctly what it does (or should do). |
Fixed for wrong recursive profiles adding for custom profiles
You suggestion is good. we had to much different ideas on how it should work. And extra got added with mass refine profiles. I think we can come to simpler solution. I like the idea with '+'. as for now I tried my best to describe in clearest way what is going on now. I also not sure why we have some lines for expand. |
Fixed for wrong recursive profiles adding for custom profiles
suggested fix for
![image](https://cloud.githubusercontent.com/assets/1182917/7842875/0a96358e-0474-11e5-965a-30728e069697.png)
we have issues with expected behavior for custom profiles. see comment below.