Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxAFCStep may be used uninitialised #56

Closed
ED6E0F17 opened this issue Jul 10, 2018 · 5 comments
Closed

MaxAFCStep may be used uninitialised #56

ED6E0F17 opened this issue Jul 10, 2018 · 5 comments

Comments

@ED6E0F17
Copy link

I may be missing something, but If I don`t set MaxAFCstep in config, I am not going to be able to use calling mode to correct drifty payloads.

@PiInTheSky
Copy link
Owner

If you don't set a value, it will be zero, which disables its action. So AFC works but isn't bounded.

@ED6E0F17
Copy link
Author

Thanks, I should have been paying more attention to the code. You could set a sensible default value, but it is not a problem.

@daveake
Copy link
Contributor

daveake commented Jul 10, 2018 via email

@ED6E0F17
Copy link
Author

My actual problem was a typo in gateway.txt: "AFC0=Y", so if you could make AFC default to on, that would be good too.......

@dbrooke
Copy link
Contributor

dbrooke commented Jul 11, 2018

AFC is only needed at the narrower bandwidth settings so it doesn't necessarily make sense to default to on.

Also you can easily toggle the setting using the f or F key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants