Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container-based service upload #25

Merged
merged 5 commits into from
Jul 2, 2019

Conversation

VertexC
Copy link
Contributor

@VertexC VertexC commented Jun 19, 2019

For single service file, it is going to be wrapped into a folder with the same name.

For container-based service(.zip),
inside myService.zip

  • myService.py (must exists)
  • requirement.txt (optional)
  • other files

The upload/delete of container-based/single file upload has been tested manually. Still looking for a better way to valid requirement.txt.

@pep8speaks
Copy link

pep8speaks commented Jun 19, 2019

Hello @VertexC, Thank you for updating the PR!

Line 16:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file

Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file
Line 48:1: E402 module level import not at top of file

Comment last updated at 2019-06-30 23:52:46 UTC

@canihavesomecoffee canihavesomecoffee changed the title Add contianer-based service upload Add container-based service upload Jun 20, 2019
Copy link
Member

@canihavesomecoffee canihavesomecoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mainly missing unittests for the new functionality :)

@canihavesomecoffee
Copy link
Member

@VertexC Please add unittests for this new functionality.

@canihavesomecoffee canihavesomecoffee merged commit e42319f into PiPot:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants