Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service models manager to keep track of db tables of service in use #33

Merged
merged 3 commits into from Aug 13, 2019

Conversation

VertexC
Copy link
Contributor

@VertexC VertexC commented Aug 5, 2019

Also update the Base.metadata object for table scheme change.

@pep8speaks
Copy link

pep8speaks commented Aug 5, 2019

Hello @VertexC, Thank you for updating the PR!

Line 19:1: E402 module level import not at top of file

Comment last updated at 2019-08-11 20:38:02 UTC

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #33 into master will increase coverage by 1.79%.
The diff coverage is 78.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   47.45%   49.24%   +1.79%     
==========================================
  Files          23       24       +1     
  Lines        1730     1799      +69     
==========================================
+ Hits          821      886      +65     
- Misses        909      913       +4
Impacted Files Coverage Δ
mod_config/forms.py 80.26% <100%> (ø) ⬆️
mod_config/controllers.py 43.7% <75.92%> (+7.79%) ⬆️
pipot/services/ServiceModelsManager.py 80% <80%> (ø)
pipot/services/ServiceLoader.py 54.23% <81.81%> (+2.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcd8ce4...da62c49. Read the comment docs.

@VertexC VertexC force-pushed the master branch 2 times, most recently from 0301178 to 7ed39f8 Compare August 11, 2019 20:36
@VertexC
Copy link
Contributor Author

VertexC commented Aug 17, 2019

fix PiPot/PiPot#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants