Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug due to the upgrade to python3, where the enum class is not iterated properly #34

Closed
wants to merge 4 commits into from

Conversation

VertexC
Copy link
Contributor

@VertexC VertexC commented Aug 13, 2019

No description provided.

@pep8speaks
Copy link

Hello @VertexC, thank you for submitting this PR!

Line 19:1: E402 module level import not at top of file

Line 51:121: E501 line too long (129 > 120 characters)
Line 65:1: E303 too many blank lines (3)

In need of guides? Guidelines for PEP-8 and Hitchhiker's guide to code style

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #34 into master will increase coverage by 2.96%.
The diff coverage is 77.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   47.45%   50.41%   +2.96%     
==========================================
  Files          23       24       +1     
  Lines        1730     1799      +69     
==========================================
+ Hits          821      907      +86     
+ Misses        909      892      -17
Impacted Files Coverage Δ
mod_config/forms.py 80.26% <100%> (ø) ⬆️
mod_honeypot/controllers.py 34.48% <66.66%> (+12.41%) ⬆️
mod_config/controllers.py 43.7% <75.92%> (+7.79%) ⬆️
pipot/services/ServiceModelsManager.py 80% <80%> (ø)
pipot/services/ServiceLoader.py 54.23% <81.81%> (+2.31%) ⬆️
decorators.py 93.44% <0%> (+1.63%) ⬆️
mod_honeypot/forms.py 66.1% <0%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcd8ce4...4c99f2e. Read the comment docs.

@VertexC VertexC closed this Aug 13, 2019
@VertexC
Copy link
Contributor Author

VertexC commented Aug 13, 2019

duplicate PR of #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants