Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Feature: add support for clipboard in wsl #87

Merged
merged 1 commit into from
Jul 27, 2021
Merged

✨ Feature: add support for clipboard in wsl #87

merged 1 commit into from
Jul 27, 2021

Conversation

JeffersonQin
Copy link
Contributor

No description provided.

Copy link
Member

@upupming upupming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffersonQin 有尝试过集成在 vs-picgo 吗,能否正常使用?

@@ -34,7 +38,8 @@ const getClipboardImage = async (ctx: IPicGo): Promise<IClipboardImage> => {
darwin: env ? path.join(ctx.baseDir, 'mac.applescript') : './clipboard/mac.applescript',
win32: env ? path.join(ctx.baseDir, 'windows.ps1') : './clipboard/windows.ps1',
win10: env ? path.join(ctx.baseDir, 'windows10.ps1') : './clipboard/windows10.ps1',
linux: env ? path.join(ctx.baseDir, 'linux.sh') : './clipboard/linux.sh'
linux: env ? path.join(ctx.baseDir, 'linux.sh') : './clipboard/linux.sh',
wsl: env ? path.join(ctx.baseDir, 'wsl.sh') : './clipboard/wsl.sh'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Molunerfinn Electron 版本应该也需要加一下这个 .sh 文件,不然可能会抛出错误

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我等会去看一下(不太熟悉这块)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Molunerfinn Electron 版本应该也需要加一下这个 .sh 文件,不然可能会抛出错误

嗯OK,合并之后会补充一下

@JeffersonQin
Copy link
Contributor Author

@JeffersonQin 有尝试过集成在 vs-picgo 吗,能否正常使用?

我本地做过测试了,等会我去vscode里test一下

@upupming
Copy link
Member

@JeffersonQin 有尝试过集成在 vs-picgo 吗,能否正常使用?

我本地做过测试了,等会我去vscode里test一下

可以的,直接用 yarn link 安装本地的最新的开发版,测一下就行了

@Molunerfinn
Copy link
Member

感谢贡献!

@Molunerfinn Molunerfinn merged commit 3e230de into PicGo:dev Jul 27, 2021
@JeffersonQin
Copy link
Contributor Author

@JeffersonQin 有尝试过集成在 vs-picgo 吗,能否正常使用?

我本地做过测试了,等会我去vscode里test一下

可以的,直接用 yarn link 安装本地的最新的开发版,测一下就行了

image

vscode测试过了,没有问题。

  • WSL Version: 1
  • WSL System: Ubuntu 18.04

@upupming
Copy link
Member

@JeffersonQin 可以的👍🏻,我下一版更新一下core。
现在你可以自己 yarn build 打个包手动安装~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants