Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested mapped parameters #166

Merged

Conversation

pac48
Copy link
Collaborator

@pac48 pac48 commented Jan 1, 2024

This issue #151 describes a problem when using multiple levels of nested maps. Currently, only one level of nesting is supported.

Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
Signed-off-by: Paul Gesel <paulgesel@gmail.com>
@pac48 pac48 changed the title upport nested mapped parameters Support nested mapped parameters Jan 1, 2024
Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to review the jinja temlates, but the code generated from the provided yaml looks good.
And I tested it with ros2_controllers, it doesn't break current configs.

Should one update the README describing this?

@pac48 pac48 force-pushed the pr-support-nested-mapped-parameters branch from 7f7c2e5 to b6633be Compare March 8, 2024 15:23
Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sea-bass sea-bass merged commit 032a74d into PickNikRobotics:main Mar 8, 2024
5 of 7 checks passed
sea-bass added a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants