Add accessibility #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgroat
reviewed
Dec 8, 2018
src/copyCodeBlock.js
Outdated
| @@ -21,12 +23,12 @@ export default (string, opts) => { | |||
| textarea.select(); | |||
|
|
|||
| button.innerHTML = 'Copied!'; | |||
| setTimeout(function() { button.innerHTML = 'Copy'; }, 1000); | |||
| setTimeout(function() { button.innerHTML = 'Click to copy'; }, 1500); | |||
There was a problem hiding this comment.
Might be a good idea to break 'Click to copy' into its own variable so it can be reused.
kgroat
approved these changes
Dec 8, 2018
Pickra
force-pushed
the
feature/addAccessibility
branch
from
5dd1e1f
to
e1f7b3c
Compare
Pickra
force-pushed
the
feature/addAccessibility
branch
from
e1f7b3c
to
8d99349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @kgroat