Add BinaryOperator to elidedTypesAndStaticImports

PicnicSupermarket · Sep 29, 2022 · b367315 · b367315
1 parent e3c784c
commit b367315
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/...e-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ComparatorTemplates.java b/...e-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ComparatorTemplates.java
@@ -263,7 +263,8 @@ T after(T value1, T value2, Comparator<T> cmp) {
   }
 
   /**
-   * Prefer {@link Comparators#min(Comparable, Comparable)} over {@link BinaryOperator#minBy(Comparator)}for natural ordering.
+   * Prefer {@link Comparators#min(Comparable, Comparable)} over {@link
+   * BinaryOperator#minBy(Comparator)}for natural ordering.
    */
   static final class BinaryOperatorMinByNaturalOrder<T extends Comparable<? super T>> {
     @BeforeTemplate
@@ -278,7 +279,8 @@ BiFunction<T, T, T> after() {
   }
 
   /**
-   * Prefer {@link Comparators#max(Comparable, Comparable)} over {@link BinaryOperator#maxBy(Comparator)}for natural ordering.
+   * Prefer {@link Comparators#max(Comparable, Comparable)} over {@link
+   * BinaryOperator#maxBy(Comparator)}for natural ordering.
    */
   static final class BinaryOperatorMaxByNaturalOrder<T extends Comparable<? super T>> {
     @BeforeTemplate
@@ -291,5 +293,4 @@ BiFunction<T, T, T> after() {
       return Comparators::max;
     }
   }
-
 }
diff --git a/...test/resources/tech/picnic/errorprone/refastertemplates/ComparatorTemplatesTestInput.java b/...test/resources/tech/picnic/errorprone/refastertemplates/ComparatorTemplatesTestInput.java
@@ -17,7 +17,12 @@ final class ComparatorTemplatesTest implements RefasterTemplateTestCase {
   @Override
   public ImmutableSet<?> elidedTypesAndStaticImports() {
     return ImmutableSet.of(
-        Arrays.class, Collections.class, ImmutableList.class, ImmutableSet.class, identity());
+        Arrays.class,
+        BinaryOperator.class,
+        Collections.class,
+        ImmutableList.class,
+        ImmutableSet.class,
+        identity());
   }
 
   ImmutableSet<Comparator<String>> testNaturalOrder() {

diff --git a/...est/resources/tech/picnic/errorprone/refastertemplates/ComparatorTemplatesTestOutput.java b/...est/resources/tech/picnic/errorprone/refastertemplates/ComparatorTemplatesTestOutput.java
@@ -11,13 +11,19 @@
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.function.BiFunction;
+import java.util.function.BinaryOperator;
 import tech.picnic.errorprone.refaster.test.RefasterTemplateTestCase;
 
 final class ComparatorTemplatesTest implements RefasterTemplateTestCase {
   @Override
   public ImmutableSet<?> elidedTypesAndStaticImports() {
     return ImmutableSet.of(
-        Arrays.class, Collections.class, ImmutableList.class, ImmutableSet.class, identity());
+        Arrays.class,
+        BinaryOperator.class,
+        Collections.class,
+        ImmutableList.class,
+        ImmutableSet.class,
+        identity());
   }
 
   ImmutableSet<Comparator<String>> testNaturalOrder() {