Enforce Refaster test code formatting #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2022
rickie
approved these changes
May 23, 2022
There was a problem hiding this comment.
I spotted this error in this bc48dc2 (#43) link by accident. I indeed found it weird that I could spot a WildcardImport in one of the PRs...
Nice that this is fixed now.
|
Alternative suggested commit message: Or "Enforce Refaster test code formatting in resources"? |
Badbond
approved these changes
May 25, 2022
There was a problem hiding this comment.
LGTM. Prefer the alternative suggested commit message. 👍
If going with other alternative of 'Enforce Refaster test code formatting in resources', I would drop he word Refaster as this is repository-wide and not only applies to Refaster-specifics in configuration.
This change should have been part of #75.
Stephan202
force-pushed
the
sschroevers/format-refaster-test-code
branch
from
dc23e64
to
f5cf142
Compare
|
Rebased and added a commit to fix some formatting. Will merge once built (with the alternative suggested commit message). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message: