Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Checkstyle integration test #1064

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Sync Checkstyle integration test #1064

merged 5 commits into from
Mar 5, 2024

Conversation

rickie
Copy link
Member

@rickie rickie commented Mar 4, 2024 •
edited by Stephan202
Loading

❗ These changes are on top of #1060 ❗

Suggested commit message:

Sync Checkstyle integration test (#1064)

Summary of changes:
- Minimize `checkstyle-init.patch`.
- Test against version 10.14.0 rather than 10.13.0.

@rickie rickie requested a review from Stephan202 March 4, 2024 06:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie changed the title Ensure integration-tests run with the new EPS version Sync Checkstyle integration test Mar 4, 2024
@rickie
Copy link
Member Author

rickie commented Mar 4, 2024

/integration-test

mohamedsamehsalah
mohamedsamehsalah approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@rickie rickie added this to the 0.16.0 milestone Mar 4, 2024
@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Mar 4, 2024
Stephan202
Stephan202 reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Will have a closer look later.

integration-tests/checkstyle-init.patch Outdated
Comment on lines 1 to 2
diff --git a/pom.xml b/pom.xml
index b6e23f5..4a09c65 100644
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below: we should omit these lines.

@rickie rickie force-pushed the rossendrijver/fix_checkstyle_with_new_setup branch from c05c467 to e51c317 Compare March 4, 2024 19:38
Base automatically changed from rossendrijver/fix_checkstyle_with_new_setup to master March 4, 2024 19:47
@Stephan202 Stephan202 force-pushed the rossendrijver/fix_checkstyle_version branch from 5badc77 to 8229a52 Compare March 5, 2024 08:03
Stephan202
Stephan202 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added two more commits. Also tweaked the suggested commit message.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie
Copy link
Member Author

rickie commented Mar 5, 2024

Two questions:

  • how do I create a diff without the meta data? Am I doing something wrong?
  • why wasn't that suppression required to have?

@rickie
Copy link
Member Author

rickie commented Mar 5, 2024

/integration-test

@Stephan202
Copy link
Member

how do I create a diff without the meta data? Am I doing something wrong?

Nope, you'll have to do this manually with grep -vP '^(diff|index)' like here.

why wasn't that suppression required to have?

Because we just merged #1056 🙃

@rickie
Copy link
Member Author

rickie commented Mar 5, 2024

Ah thanks, now I know it for next time 😉.

Because we just merged #1056 🙃

😂 Damn, how stupid of me 😅.

@rickie rickie force-pushed the rossendrijver/fix_checkstyle_version branch from 8229a52 to 7358c22 Compare March 5, 2024 19:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie merged commit e9263d9 into master Mar 5, 2024
15 checks passed
@rickie rickie deleted the rossendrijver/fix_checkstyle_version branch March 5, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees
No one assigned
Labels
chore A task not related to code (build, formatting, process, ...)
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickie @Stephan202 @mohamedsamehsalah