Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a BugPattern to sort annotations lexicographically #11

Merged
merged 19 commits into from
Feb 28, 2021
Merged

Add a BugPattern to sort annotations lexicographically #11

merged 19 commits into from
Feb 28, 2021

Conversation

rickie
Copy link
Member

@rickie rickie commented Feb 8, 2021

No description provided.

@rickie
Copy link
Member Author

rickie commented Feb 8, 2021

@Stephan202 there is one thing in the Repeatable annotations I don't understand, that is why the tests fail. Let's take a look next time!

@rickie rickie added the WIP Work in progress label Feb 8, 2021
@rickie rickie changed the title WIP: Add a BugPattern for ordering annotations lexicographical Add a BugPattern for ordering annotations lexicographical Feb 8, 2021
@rickie rickie changed the title Add a BugPattern for ordering annotations lexicographical Add a BugPattern to sort annotations lexicographically Feb 11, 2021
@rickie rickie removed the WIP Work in progress label Feb 11, 2021
@Stephan202 Stephan202 force-pushed the rossendrijver/lexicographical_annotation_check branch from 4938746 to 1945ca0 Compare February 14, 2021 16:43
Stephan202
Stephan202 reviewed Feb 14, 2021
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a small commit. Still have to check the tests, but: LGTM so far!

...rone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/AutowiredConstructorCheck.java Outdated Show resolved Hide resolved
...contrib/src/main/java/tech/picnic/errorprone/bugpatterns/LexicographicalAnnotationCheck.java Outdated Show resolved Hide resolved
rickie and others added 18 commits February 27, 2021 08:23
@rickie @Stephan202
First push for lexicographical annotation check
b68d8b0
@rickie @Stephan202
Add a set with ordered annotations
ce33510
@rickie @Stephan202
Add check if orders are equal
f5c4f8d
@rickie @Stephan202
Try to find out how to provide a fix for the annotations
94f85ad
@rickie @Stephan202
Improve annotation retrieval and remove old stuff
1a2001e
@rickie @Stephan202
First working suggestedFix
85caf0c
@rickie @Stephan202
Remove some unnecessary code
4e8f477
@rickie @Stephan202
Cleanup and renaming some things
dc9db8d
@rickie @Stephan202
Improve description returning by now use builder
5f9a879
@rickie @Stephan202
Add some tests to the lexico ann check
e2fafa8
@rickie @Stephan202
Remove iterator use, just check via equals
518cbbf
@rickie @Stephan202
Remove deprecated field providesFix
161a9fd
@rickie @Stephan202
Add test cases and replace tests
0229688
@rickie @Stephan202
Remove unused import and rename typo
63fa7eb
@rickie @Stephan202
Remove unused imports from test
47cf7bb
@rickie @Stephan202
Fix the test, it failed because of ascii order
c4f8eb4
@rickie @Stephan202
Add last test and fix the test
04162f0
@Stephan202
Tweaks
835811d
@Stephan202 Stephan202 force-pushed the rossendrijver/lexicographical_annotation_check branch from cd5d529 to 835811d Compare February 27, 2021 07:33
Stephan202
Stephan202 approved these changes Feb 27, 2021
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a commit. Suggested commit message:

Flag unordered annotation declarations (#11)

Will merge if you're okay with the changes.

@rickie
Copy link
Member Author

rickie commented Feb 28, 2021

Looks good! Let's merge :D

@Stephan202 Stephan202 merged commit e84d0e1 into master Feb 28, 2021
@Stephan202 Stephan202 deleted the rossendrijver/lexicographical_annotation_check branch February 28, 2021 13:42
@Stephan202 Stephan202 added this to the 0.1.0 milestone Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rickie @Stephan202