Prefer the lazy version of Mono#fromFuture
#1244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. No mutations were possible for these changes. |
|
Venorcis
changed the title
Mono#fromFuture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Futures subscribe eagerly. This means that
Mono#fromFuture(CompletableFuture)already executes the contents of the future on assembly time (even when thatFutureis constructed from aMonoas we do in our reactive Caffeine caches).I therefore suggest instead to always use
Mono#fromFuture(Supplier), which will only instantiate (and thus execute) the future on subscription, i.e. much closer to how we usually do everything 😄